From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add some error checking to DWARF assembler
Date: Wed, 31 Mar 2021 21:07:54 +0100 [thread overview]
Message-ID: <20210331200754.GB5391@embecosm.com> (raw)
In-Reply-To: <874kgrtkg0.fsf@tromey.com>
* Tom Tromey <tromey@adacore.com> [2021-03-31 09:24:47 -0600]:
> Andrew> Maybe I'm over thinking this, but you could change this to:
> Tom> Here's the definitive (IMNSHO) over-thinking approach. It works by
> Tom> having the helper proc set the necessary variables for the caller.
>
> Tom> One problem I thought of with that approach is that if you typo the code
> Tom> in one case, you could pick up a local variable set from some previous
> Tom> case.
>
> Tom> Switching this to use an array that's cleared after every opcode avoids
> Tom> this problem.
>
> I'm checking this in now.
Sorry, I missed your updates. The new patch looks great.
Thanks,
Andrew
prev parent reply other threads:[~2021-03-31 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 15:58 Tom Tromey
2021-03-18 17:15 ` Andrew Burgess
2021-03-18 18:22 ` Tom Tromey
2021-03-18 21:15 ` Tom Tromey
2021-03-31 15:24 ` Tom Tromey
2021-03-31 20:07 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331200754.GB5391@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).