[PATCH] sim/m32c: fix memory leaks in opc2c

[Simon Marchi <simon.marchi@polymtl.ca>]

When building with AddressSanitizer, sim/m32c fails with:

./opc2c -l r8c.out /home/simark/src/binutils-gdb/sim/m32c/r8c.opc > r8c.c
sim_log: r8c.out

=================================================================
==3919390==ERROR: LeakSanitizer: detected memory leaks

    Direct leak of 485 byte(s) in 131 object(s) allocated from:
        #0 0x7ffff761fa69 in __interceptor_strdup /build/gcc/src/gcc/libsanitizer/asan/asan_interceptors.cpp:452
        #1 0x555555557abe in dump_lines /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:243
        #2 0x555555558bc9 in emit_indirect /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:382
        #3 0x555555558c66 in emit_indirect /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:387
        #4 0x55555555c463 in main /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:718
        #5 0x7ffff741fb24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)

    Direct leak of 360 byte(s) in 100 object(s) allocated from:
        #0 0x7ffff761fa69 in __interceptor_strdup /build/gcc/src/gcc/libsanitizer/asan/asan_interceptors.cpp:452
        #1 0x555555557abe in dump_lines /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:243
        #2 0x555555558bc9 in emit_indirect /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:382
        #3 0x55555555c463 in main /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:718
        #4 0x7ffff741fb24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)

    Direct leak of 4 byte(s) in 1 object(s) allocated from:
        #0 0x7ffff7677459 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:145
        #1 0x55555555b3df in main /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:658
        #2 0x7ffff741fb24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)

Fix the leak in dump_lines by free-ing the elements of varnames.

Fix the leak in main by removing the vlist variable, which seems unused.

sim/m32c/ChangeLog:

	* opc2c.c (dump_lines): Free elements of varnames.
	(main): Remove vlist variable.

Change-Id: I5a92fd229da623bd32841b083c54c5c868455e91
---
 sim/m32c/opc2c.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sim/m32c/opc2c.c b/sim/m32c/opc2c.c
index 082d4e9b8a42..7d1604f4fb3a 100644
--- a/sim/m32c/opc2c.c
+++ b/sim/m32c/opc2c.c
@@ -286,6 +286,9 @@ dump_lines (opcode * op, int level, Indirect * ind)
     printf ("%*s%s", level, "", op->lines[i]);
   if (op->comment)
     printf ("%*s}\n", level, "");
+
+  for (i = 0; i < vn; i++)
+    free (varnames[i]);
 }
 
 void
@@ -507,7 +510,6 @@ main (int argc, char **argv)
   FILE *in;
   int lineno = 0;
   int i;
-  VaryRef *vlist;
 
   if (argc > 2 && strcmp (argv[1], "-l") == 0)
     {
@@ -655,8 +657,6 @@ main (int argc, char **argv)
 
   qsort (opcodes, n_opcodes, sizeof (opcodes[0]), op_cmp);
 
-  vlist = (VaryRef *) malloc (n_varies * sizeof (VaryRef));
-
   for (i = 0; i < n_opcodes; i++)
     {
       int j, b, v;
-- 
2.30.1