public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ulrich Weigand <uweigand@de.ibm.com>
To: will schmidt <will_schmidt@vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,rs6000] Fix vsx-regs.exp testcase failure
Date: Tue, 6 Apr 2021 18:15:49 +0200	[thread overview]
Message-ID: <20210406161549.GA19230@oc3748833570.ibm.com> (raw)
In-Reply-To: <3f9ea0771af5b59585df53000683aa8298ec4af2.camel@vnet.ibm.com>

On Thu, Apr 01, 2021 at 03:39:26PM -0500, will schmidt wrote:
> 
> Hi,
>   This test (gdb.arch/vsx-regs.exp) exercises updates to the
> F0-F31 and VS0-VS31 registers and verifies updates to the same.
> Note that the registers overlap; the doubleword[1] portion of
> any VS0-VS31 register contains the F0-F31 register contents, so
> any updates to one can be measured in the other.
> 
> Per a brief investigation, we see that dl_main() currently
> uses some VSX instructions, so the VS* values are not
> going to be zero when this testcase reaches main, where these
> tests begin.  The test harness does not explicitly
> initialize the full VS* values, so the first test loop
> that updates the F* values means our VS* values are
> partially uninitalized and will fail the first set of checks.
> This update explicitly initializes the doubleword[0] portion
> of the VS* registers, to allow this test to succeed.
> 
> YYYY-MM-DD  Will Schmidt  <will_schmidt@vnet.ibm.com>
> 
> gdb/testsuite/ChangeLog:
> 	* gdb.arch/vsx-regs.exp: Initilize vs* doublewords.

Typo "Initialize".  Otherwise this is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

      reply	other threads:[~2021-04-06 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 20:39 will schmidt
2021-04-06 16:15 ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210406161549.GA19230@oc3748833570.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).