From: Luis Machado <luis.machado@linaro.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] [sim,moxie] Fix DTB generation mechanism and build failure
Date: Wed, 7 Apr 2021 16:39:29 -0300 [thread overview]
Message-ID: <20210407193929.1251903-1-luis.machado@linaro.org> (raw)
I ran into a build failure with --enable-targets=all due to the fact that
the moxie sim expects to be able to use the dtc tool. If it isn't available,
the builds fails.
Given the device tree compiler (dtc) is not available everywhere, it seems
fair to only generate the DTB file on the spot if we have such a tool. For
those who don't have the tool available, we can use a prebuilt version of the
DTB available in the repository.
The DTS file hasn't changed since ~2009, so it seems pretty safe to assume
a prebuilt version is suitable to be used.
I also checked that the DTB file generated on an x86_64-Linux machine is the
the same as the one generated on an AArch64-Linux machine.
Tested by running make/make install with/without the dtc tool.
---
sim/moxie/Makefile.in | 12 ++++++++++--
sim/moxie/moxie-gdb.dtb | Bin 0 -> 519 bytes
2 files changed, 10 insertions(+), 2 deletions(-)
create mode 100644 sim/moxie/moxie-gdb.dtb
diff --git a/sim/moxie/Makefile.in b/sim/moxie/Makefile.in
index ee513867290..65c41e6c2ac 100644
--- a/sim/moxie/Makefile.in
+++ b/sim/moxie/Makefile.in
@@ -17,6 +17,8 @@
## COMMON_PRE_CONFIG_FRAG
+DTC = @DTC@
+
dtbdir = @datadir@/gdb/dtb
SIM_OBJS = \
@@ -33,8 +35,14 @@ SIM_EXTRA_CFLAGS = -DDTB="\"$(dtbdir)/moxie-gdb.dtb\""
all: moxie-gdb.dtb
moxie-gdb.dtb: moxie-gdb.dts
- dtc -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts
+ if test "x$(DTC)" != x; then \
+ $(DTC) -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts ; \
+ fi ;
install-dtb: moxie-gdb.dtb
$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(dtbdir)
- $(INSTALL_DATA) moxie-gdb.dtb $(DESTDIR)$(dtbdir)/moxie-gdb.dtb
+ if test "x$(DTC)" = x; then \
+ $(INSTALL_DATA) $(srcdir)/moxie-gdb.dtb $(DESTDIR)$(dtbdir)/moxie-gdb.dtb ; \
+ else \
+ $(INSTALL_DATA) moxie-gdb.dtb $(DESTDIR)$(dtbdir)/moxie-gdb.dtb ; \
+ fi ;
diff --git a/sim/moxie/moxie-gdb.dtb b/sim/moxie/moxie-gdb.dtb
new file mode 100644
index 0000000000000000000000000000000000000000..4c7e4570438a62b81df2021bb4c955d9888d2a8b
GIT binary patch
literal 519
zcmZ8d%}T^D5T34riikhgUWA3kLo4;>f(v``<U>fCjx~}tA<2sM>|^;5zKE|N&LrtB
z8ko*}U%r{nm#>qbZ-ChW0Nes(pOmjC&MD3)_&gB*5z9Z{ETKKh`>AGb!lzVE_=4)Z
zYn!6iZxTyXPbHz)#QH;ug-7S*&@r3!*lRnkt8|!S9q(DhJEj81y|nvwi5Zodc-9UF
zW`icDe5cII>V^hh3OzWjaD}y1qeEK-UF<U(7tqcJ!^sExy#I&UC!b81%{q<>|KvB!
zgWu%3x?V1WayPr69;VpaF~uV4x60`)gFm|G9j7>&*KKRjxl*7~4(3k2W2%MjP3>i)
d5PIFBf)-z;z(+qC1dAOsTKn2|)I}RO_yq~^OHTj*
literal 0
HcmV?d00001
--
2.25.1
next reply other threads:[~2021-04-07 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 19:39 Luis Machado [this message]
2021-04-07 20:26 ` Mike Frysinger
2021-04-07 20:39 ` Luis Machado
2021-04-07 22:31 ` Mike Frysinger
2021-04-08 14:40 ` Luis Machado
2021-04-08 14:40 ` [PATCH,v2][sim,moxie] " Luis Machado
2021-04-08 16:37 ` Mike Frysinger
2021-04-08 17:21 ` [PATCH,v3][sim,moxie] " Luis Machado
2021-04-08 17:44 ` Mike Frysinger
2021-04-08 18:03 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407193929.1251903-1-luis.machado@linaro.org \
--to=luis.machado@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).