public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Zied Guermazi <zied.guermazi@trande.de>
To: gdb-patches@sourceware.org
Cc: Zied Guermazi <zied.guermazi@trande.de>
Subject: [PATCH v4 5/7] fix issue: gdb hangs in the command following a commad returning with TARGET_WAITKIND_NO_HISTORY
Date: Sat, 10 Apr 2021 23:17:42 +0200	[thread overview]
Message-ID: <20210410211744.7662-6-zied.guermazi@trande.de> (raw)
In-Reply-To: <20210410211744.7662-1-zied.guermazi@trande.de>


This patch fixes an issue observed with btrace when replaying the execution.
The issue was observed on ARMv7 processors.
To reproduce the issue, the user needs to replay in forward direction 
until he reaches the end of history, then replay backwards 
(e.g a reverse-next) and then replay forwards. GDB hangs and the user
can not issue new commands.
This fix keeps the same behaviour of gdb as when TARGET_WAITKIND_NO_HISTORY
is hit on other architectures.

gdb/ChangeLog

	* infrun.c (set_step_over_info): add debug print.
	(handle_inferior_event): clear step over info 
	in case TARGET_WAITKIND_NO_HISTORY.

---
 gdb/infrun.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/infrun.c b/gdb/infrun.c
index a271220b261..9c2522376f2 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -1308,6 +1308,7 @@ set_step_over_info (const address_space *aspace, CORE_ADDR address,
 		    int nonsteppable_watchpoint_p,
 		    int thread)
 {
+  infrun_debug_printf ("setting step over info");
   step_over_info.aspace = aspace;
   step_over_info.address = address;
   step_over_info.nonsteppable_watchpoint_p = nonsteppable_watchpoint_p;
@@ -5536,7 +5537,7 @@ handle_inferior_event (struct execution_control_state *ecs)
       delete_just_stopped_threads_single_step_breakpoints ();
       ecs->event_thread->suspend.stop_pc
 	= regcache_read_pc (get_thread_regcache (inferior_thread ()));
-
+      clear_step_over_info ();
       if (handle_stop_requested (ecs))
 	return;
 
-- 
2.25.1


  parent reply	other threads:[~2021-04-10 21:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 21:17 [PATCH v4 0/7] extend branch tracing to use ARM CoreSight traces Zied Guermazi
2021-04-10 21:17 ` [PATCH v4 1/7] configure gdb build system for supporting btrace on arm processors Zied Guermazi
2021-04-10 22:40   ` Simon Marchi
2021-04-11  0:35     ` Zied Guermazi
2021-04-11  1:09       ` Simon Marchi
2021-04-11  1:14         ` Zied Guermazi
2021-04-11  1:45           ` simon.marchi
2021-04-10 21:17 ` [PATCH v4 2/7] add btrace coresight related commands Zied Guermazi
2021-04-11  6:41   ` Eli Zaretskii
2021-04-10 21:17 ` [PATCH v4 3/7] start/stop btrace with coresight etm and parse etm buffer. nat independant Zied Guermazi
2021-04-10 21:17 ` [PATCH v4 4/7] start/stop btrace with coresight etm and collect etm buffer on linux os Zied Guermazi
2021-04-10 21:17 ` Zied Guermazi [this message]
2021-04-10 21:17 ` [PATCH v4 6/7] add support for coresight btrace via remote protocol Zied Guermazi
2021-04-11  6:43   ` Eli Zaretskii
2021-04-10 21:17 ` [PATCH v4 7/7] adapt btrace testcases for arm target Zied Guermazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210410211744.7662-6-zied.guermazi@trande.de \
    --to=zied.guermazi@trande.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).