From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nx223.node02.secure-mailgate.com (nx223.node02.secure-mailgate.com [192.162.87.223]) by sourceware.org (Postfix) with ESMTPS id 248833865488 for ; Sat, 10 Apr 2021 21:17:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 248833865488 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=trande.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zied.guermazi@trande.de Received: from host202.checkdomain.de ([185.137.168.148]) by node02.secure-mailgate.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1lVKzM-00AU8m-J5 for gdb-patches@sourceware.org; Sat, 10 Apr 2021 23:17:57 +0200 X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de Received: from Trande0001.fritz.box (x4db55ac6.dyn.telefonica.de [77.181.90.198]) (Authenticated sender: zied.guermazi@trande.de) by host202.checkdomain.de (Postfix) with ESMTPSA id 12965280096; Sat, 10 Apr 2021 23:17:56 +0200 (CEST) X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de From: Zied Guermazi To: gdb-patches@sourceware.org Cc: Zied Guermazi Subject: [PATCH v4 5/7] fix issue: gdb hangs in the command following a commad returning with TARGET_WAITKIND_NO_HISTORY Date: Sat, 10 Apr 2021 23:17:42 +0200 Message-Id: <20210410211744.7662-6-zied.guermazi@trande.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210410211744.7662-1-zied.guermazi@trande.de> References: <20210410211744.7662-1-zied.guermazi@trande.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-PPP-Message-ID: <20210410211756.2587287.14317@host202.checkdomain.de> X-PPP-Vhost: trande.de X-Originating-IP: 185.137.168.148 X-SecureMailgate-Domain: host202.checkdomain.de X-SecureMailgate-Username: 185.137.168.148 Authentication-Results: secure-mailgate.com; auth=pass smtp.auth=185.137.168.148@host202.checkdomain.de X-SecureMailgate-Outgoing-Class: ham X-SecureMailgate-Outgoing-Evidence: Combined (0.04) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT+EC+/QgSrq1dFokvSSt9WhPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wgSQOko5ya3orWH1MkzQXa2oPZqVS5i0KNMNtVCi0tRw/C h5SE4jAyhe1COeASyU8rrQw738tU8i15V3FEwtYH4ld5rdi2ZxohSIq+dqifZoVY3IcDeckxfee+ NDQ6wUl3g/WbBekzB3IK8RY7uNAEcY1i02TJefD768F5oV2iM8C0xB8SW32wy2mbLZXD/P+t8ebU KGAHl/zKrzp4ep5Out5PpkrBQueV+Yg5wqLK/LXDLRhLABXs81Y8X58rOcwLMK9HC+pUQBAyR03+ Yzd8ARsynxDH0D+SLDJWdESXziw50BoEYB44qFPH6be8XgtMhiMRK0C70oXENkWqJaNtpfX1h/uL cDQJCG2naSen4S0KEAnwyE9dte+FkDKSV99EDBffVZVjmVaNbG4ZJG7F2RgQw3d3zmVen9wp80qQ nk5/t+UnI24Hleg6UWHjmGmLb5mum9xAXSaS3KKPtTZXWZip9+GhedmPokL8D3vhvahEk99rw1D2 l4a96yndXIAi94PWRqqg5f2zj0Czwt/2p7q+TsC7yjBBM4GUNkApbtfNeYdo3zQkL6d8fnrVN7/o G2luZ2kwu8znxkHgZW9l++DuIQUs/5JJj4C/n4CILuHmHOYlZT6wp+jJoJHpQBB6RRqmXD8xjvjO wLuNJ9Dg/a1r4yLUFJWAAOfSBV2TCrZvG6g/HuvmrLCiD+ucDmeMOC1XYD6oENz9RSepjWumxMww lmJT37b8CHOVqIzTPPdjzQ6YC7Heg3Xf7O1TOd61f628jJZW6EmR3fQuCfTT1zqyACU+4Rd8whTK dl5wejr4iz8VEx4khrInRNgOKhGKoi9TCwtcrpHeUEm/ks4wZuM7jUXIESohoO51xWmU8e2ATa/l PFbC7mHZO6K28yiwInQ++pv7Ng60eviJn4ZcguZm/om7W4zIghViJ9dWi1BCFDdxe1OpmDrNi/71 5+xlV0jhvow/FYacDOLJ9p+/d238YjBdkVxGcor5nDrEAgzYc1X3WAFlD/U9uzx6jri9gThRk31T Rgf1b+pEf0gQDNwaU/TXHJLE1rXYU2nwSGYnRfVgnnPoPsK4CB595Ss= X-Report-Abuse-To: spam@node04.secure-mailgate.com X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2021 21:17:59 -0000 This patch fixes an issue observed with btrace when replaying the execution. The issue was observed on ARMv7 processors. To reproduce the issue, the user needs to replay in forward direction until he reaches the end of history, then replay backwards (e.g a reverse-next) and then replay forwards. GDB hangs and the user can not issue new commands. This fix keeps the same behaviour of gdb as when TARGET_WAITKIND_NO_HISTORY is hit on other architectures. gdb/ChangeLog * infrun.c (set_step_over_info): add debug print. (handle_inferior_event): clear step over info in case TARGET_WAITKIND_NO_HISTORY. --- gdb/infrun.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index a271220b261..9c2522376f2 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -1308,6 +1308,7 @@ set_step_over_info (const address_space *aspace, CORE_ADDR address, int nonsteppable_watchpoint_p, int thread) { + infrun_debug_printf ("setting step over info"); step_over_info.aspace = aspace; step_over_info.address = address; step_over_info.nonsteppable_watchpoint_p = nonsteppable_watchpoint_p; @@ -5536,7 +5537,7 @@ handle_inferior_event (struct execution_control_state *ecs) delete_just_stopped_threads_single_step_breakpoints (); ecs->event_thread->suspend.stop_pc = regcache_read_pc (get_thread_regcache (inferior_thread ())); - + clear_step_over_info (); if (handle_stop_requested (ecs)) return; -- 2.25.1