From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 359473857036 for ; Wed, 14 Apr 2021 09:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 359473857036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x336.google.com with SMTP id o21-20020a1c4d150000b029012e52898006so559645wmh.0 for ; Wed, 14 Apr 2021 02:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JmOMD0so/r/mwVw1APh/hNUzVhkQ2VqVHfTjs/ZQn+c=; b=hpqRh9E6lTH+CGaVLMX30ExVxBbeOx3XIi/ft70xyaqyx9BPSt/KTNS6u7bON6TwED siKAIZtyGn4AtgTQ1qoL+8mAJTfH8NTWgVp3bc09uXgPJ58UxD3Jun0+814Tk8ssfDdX SGvJQyzDUpqcD06mfSijdQ4JJFVuRKQ+6M46iCJkDitcDNPpWBIDvmJDfBGq4fHevLL/ 5jNMe0IF4jy7Ci9n5z4YaEUgUjzFSvB9zCAfUPIgCbKQ55VxhixJw/OT65UtO2O3IU/Z Aq0BVYEiqv1EQ6Mh3MLFlg1xUURgDpdu8IaLjb8Q8Ws0DrS1fo7tO88DqNJnMlN3pedm 2ZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JmOMD0so/r/mwVw1APh/hNUzVhkQ2VqVHfTjs/ZQn+c=; b=BxNIP0yXG3gMh/enSPtsELY8KI6H8GgSUqrLmDm8F3C2OX/9Dry4FVEKqY2Pap0JVp VXd5lcPbqBmAjYo+SgvEXSxbM7b3xTBOGd+VtVI0vJ6jrnMuFun5/Y1tpVxOaU7u7fpx 6j4Hludim1Nej59i9n7l+19Nrv4fq+vJ5DIsM7arwM+SXVOMNZOBbxkzQLLghpc18OBc cK30knzVgQe0pgtHzeUKJKmJT7wcj4VpoBE1o2ts3IaOI9uGqRAAdYW9VJxc1qMMNCmC 9ez6gktcTWcOLVrQ1BPvP7v5apB4/dFAWTrHqMpdAJatFeGIU+2ir+/UYM+TeMe3Vc0i NLgg== X-Gm-Message-State: AOAM532Pmm73/ugdTnTup3GvFH4TSgIeLvHz8YrRZHdW/mOOwrNBJUmJ SaYk4QdW1HK8w9EOQYR39+SyAg== X-Google-Smtp-Source: ABdhPJwC7Plc12Tm2dXhdtIHM21niWMpff13AYlwPr3dQr6NpHRP/4/IdQaOIVtOlVMhdL0Q8xVA2A== X-Received: by 2002:a1c:7207:: with SMTP id n7mr2088879wmc.11.1618393812283; Wed, 14 Apr 2021 02:50:12 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id b187sm4865757wmh.17.2021.04.14.02.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 02:50:11 -0700 (PDT) Date: Wed, 14 Apr 2021 10:50:10 +0100 From: Andrew Burgess To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] testsuite, gdb: recognize DW_OP_fbreg in lib/dwarf.exp Message-ID: <20210414095010.GA2610@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:49:59 up 3 days, 20:37, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 09:50:15 -0000 * Tankut Baris Aktemur via Gdb-patches [2021-04-14 10:14:30 +0200]: > gdb/testsuite/ChangeLog: > 2021-04-14 Tankut Baris Aktemur > > * lib/dwarf.exp (_location): Recognize DW_OP_fbreg as an op. LGTM. Thanks, Andrew > --- > gdb/testsuite/lib/dwarf.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp > index f6a35749cab..e4dc284f4ee 100644 > --- a/gdb/testsuite/lib/dwarf.exp > +++ b/gdb/testsuite/lib/dwarf.exp > @@ -1211,6 +1211,11 @@ namespace eval Dwarf { > _op .sleb128 $argvec(offset) > } > > + DW_OP_fbreg { > + _get_args $line $opcode offset > + _op .sleb128 $argvec(offset) > + } > + > default { > if {[llength $line] > 1} { > error "Unimplemented: operands in location for $opcode" > -- > 2.17.1 >