From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 389E83940CF0 for ; Wed, 28 Apr 2021 16:54:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 389E83940CF0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x332.google.com with SMTP id n84so7031994wma.0 for ; Wed, 28 Apr 2021 09:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XIC6OVvL2c2swlEQSOAcOtdcmGeqJKLSCsiKz6OX0EE=; b=QwT7Xpv5dMKAXCvp6TCJHhjswZKOWuULTRmecdSz1hoVYhkpcess+HMhaMgk3ocVpL LvImZ7OiqY031BU8Zw97Nk5GGsfh+p3V8pego1+FqMv0erqEwLd9pkwiM2PeGMDaVn+T I0sj1F35Cqmr4CAdw1fWJv8OZvLEsjmaDJM8UeXYttQj7AvuDaD40l1yfQbG9SiL3HiR RvpjxhuVSazTFIVO9UA1aF3OLYYuvNwlQQ5qjly0ds0np2zv/AhjAza8G7EPW2xMFRJA nZTEaaYOQEkRuKYHAcuaLZljV7JYguvjw3dNjlDVWPS8mq4kc75gIN7Gv/VJlX/2eVId 8/KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XIC6OVvL2c2swlEQSOAcOtdcmGeqJKLSCsiKz6OX0EE=; b=uEG40Sd+Xij+B8a4ZYdUaB2AJi6SoQNtqsw1ldevq8kEnQWiU9yLGG6pBHzZNTnLOU wpWJfMoxecJaGy2TrvAbLyZMhIFCLk05JPXEN/j6fe0YNkt705le2HEyDO6uGtbeRfMx FuhN9NmFvroaubd6V1PBGz7SLh0++EFrIbPDSK1mxIqWWtCNbpvvTJaaVAm2ohOTMRMU vf5157wk7cjTxBfFU2QjCaU5xk+sIBAfO3mkEhid2djOGLfpct/Le4KSAtlDNqN+Qra/ NWJJxCECYqiwAybF6hDDvoQacC4oTmjYZUk/nL13aiLVhZk7SBb49Ejv5HFpQP/arN1y dSOw== X-Gm-Message-State: AOAM532hW1S1wJQ9SrKnPG8RRQ3Ws0PkE8m9bbIY08Hr+O996gaJxTqE jox0vOXpW1CrEltdlTQcCvUhGILlK6qW6g== X-Google-Smtp-Source: ABdhPJzU6vxvTqZsSdSHgThJG96/69wrezvHz5EOxSD0pV1k8GpasZukNwQ4Db7pZ/SNGqpyXAi1lg== X-Received: by 2002:a7b:cde1:: with SMTP id p1mr5534608wmj.6.1619628870182; Wed, 28 Apr 2021 09:54:30 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id b202sm7459114wmb.5.2021.04.28.09.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 09:54:29 -0700 (PDT) Date: Wed, 28 Apr 2021 17:54:28 +0100 From: Andrew Burgess To: George Barrett Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 1/3] Guile: improved rvalue reference support Message-ID: <20210428165428.GA2364578@embecosm.com> References: <&e1lx8mojs1b03hu3o_asydo0za8-nyh&337akgbzjn.o13/-otj@mail.bob131.so> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 17:53:49 up 18 days, 3:40, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 16:54:32 -0000 * George Barrett via Gdb-patches [2021-04-29 02:27:26 +1000]: > Adds a couple of missing bits to the Guile API to make C++11 rvalue > reference values and types usable from Guile scripts. > > gdb/ChangeLog: > > 2021-04-29 George Barrett > > * guile/scm-type.c (type_integer_constants): Add binding for > TYPE_CODE_RVALUE_REF. > * guile/scm-value.c (gdbscm_value_referenced_value): Handle > dereferencing of rvalue references. > * NEWS (Guile API): Note improvements in rvalue reference > support. > > gdb/doc/ChangeLog: > > 2021-04-29 George Barrett > > * guile.texi (Types In Guile): Add documentation for > TYPE_CODE_RVALUE_REF. Looks good to me. Thanks, Andrew > --- > gdb/NEWS | 7 +++++++ > gdb/doc/guile.texi | 3 +++ > gdb/guile/scm-type.c | 1 + > gdb/guile/scm-value.c | 1 + > 4 files changed, 12 insertions(+) > > diff --git a/gdb/NEWS b/gdb/NEWS > index 6550ea352ac..9c76df8b6d5 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -185,6 +185,13 @@ QMemTags > Request the remote to store the specified allocation tags to the requested > memory range. > > +* Guile API > + > + ** Improved support for rvalue reference values: > + TYPE_CODE_RVALUE_REF is now exported as part of the API and the > + value-referenced-value procedure now handles rvalue reference > + values. > + > *** Changes in GDB 10 > > * There are new feature names for ARC targets: "org.gnu.gdb.arc.core" > diff --git a/gdb/doc/guile.texi b/gdb/doc/guile.texi > index 762a82a08c5..c7904574002 100644 > --- a/gdb/doc/guile.texi > +++ b/gdb/doc/guile.texi > @@ -1268,6 +1268,9 @@ A pointer-to-member. > @item TYPE_CODE_REF > A reference type. > > +@item TYPE_CODE_RVALUE_REF > +A C@t{++}11 rvalue reference type. > + > @item TYPE_CODE_CHAR > A character type. > > diff --git a/gdb/guile/scm-type.c b/gdb/guile/scm-type.c > index 8d9c2c5f9a4..d65102b01c7 100644 > --- a/gdb/guile/scm-type.c > +++ b/gdb/guile/scm-type.c > @@ -1318,6 +1318,7 @@ static const scheme_integer_constant type_integer_constants[] = > X (TYPE_CODE_METHODPTR), > X (TYPE_CODE_MEMBERPTR), > X (TYPE_CODE_REF), > + X (TYPE_CODE_RVALUE_REF), > X (TYPE_CODE_CHAR), > X (TYPE_CODE_BOOL), > X (TYPE_CODE_COMPLEX), > diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c > index 59995169cd0..f50e8b5b46c 100644 > --- a/gdb/guile/scm-value.c > +++ b/gdb/guile/scm-value.c > @@ -476,6 +476,7 @@ gdbscm_value_referenced_value (SCM self) > res_val = value_ind (value); > break; > case TYPE_CODE_REF: > + case TYPE_CODE_RVALUE_REF: > res_val = coerce_ref (value); > break; > default: > -- > 2.30.2