* [PATCH] gdb/doc: reword a sentence
@ 2021-05-09 16:29 Andrew Burgess
2021-05-09 16:54 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Burgess @ 2021-05-09 16:29 UTC (permalink / raw)
To: gdb-patches
Change this:
The available watchpoint types represented by constants are defined
in the gdb module:
to this:
The available watchpoint types are represented by constants defined
in the gdb module:
The new version matches a similar line a few lines up the document
which reads:
The available types are represented by constants defined in the gdb
module:
gdb/doc/ChangeLog:
* python.texinfo (Breakpoints In Python): Reword sentence.
---
gdb/doc/ChangeLog | 4 ++++
gdb/doc/python.texi | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index 453ddfec03f..4865634537d 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5500,7 +5500,7 @@
Hardware assisted access watchpoint.
@end vtable
-The available watchpoint types represented by constants are defined in the
+The available watchpoint types are represented by constants defined in the
@code{gdb} module:
@vtable @code
--
2.25.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb/doc: reword a sentence
2021-05-09 16:29 [PATCH] gdb/doc: reword a sentence Andrew Burgess
@ 2021-05-09 16:54 ` Eli Zaretskii
2021-05-10 9:11 ` Andrew Burgess
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-05-09 16:54 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Sun, 9 May 2021 17:29:18 +0100
>
> gdb/doc/ChangeLog:
>
> * python.texinfo (Breakpoints In Python): Reword sentence.
> ---
> gdb/doc/ChangeLog | 4 ++++
> gdb/doc/python.texi | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 453ddfec03f..4865634537d 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -5500,7 +5500,7 @@
> Hardware assisted access watchpoint.
> @end vtable
>
> -The available watchpoint types represented by constants are defined in the
> +The available watchpoint types are represented by constants defined in the
> @code{gdb} module:
>
> @vtable @code
> --
> 2.25.4
Thanks, this is OK.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb/doc: reword a sentence
2021-05-09 16:54 ` Eli Zaretskii
@ 2021-05-10 9:11 ` Andrew Burgess
2021-05-10 13:38 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Burgess @ 2021-05-10 9:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
* Eli Zaretskii <eliz@gnu.org> [2021-05-09 19:54:35 +0300]:
> > From: Andrew Burgess <andrew.burgess@embecosm.com>
> > Date: Sun, 9 May 2021 17:29:18 +0100
> >
> > gdb/doc/ChangeLog:
> >
> > * python.texinfo (Breakpoints In Python): Reword sentence.
> > ---
> > gdb/doc/ChangeLog | 4 ++++
> > gdb/doc/python.texi | 2 +-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> > index 453ddfec03f..4865634537d 100644
> > --- a/gdb/doc/python.texi
> > +++ b/gdb/doc/python.texi
> > @@ -5500,7 +5500,7 @@
> > Hardware assisted access watchpoint.
> > @end vtable
> >
> > -The available watchpoint types represented by constants are defined in the
> > +The available watchpoint types are represented by constants defined in the
> > @code{gdb} module:
> >
> > @vtable @code
> > --
> > 2.25.4
>
> Thanks, this is OK.
Thanks for the review. I realised the same mistake was present in the
guile.texi file too so I extended the patch to cover that file too.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb/doc: reword a sentence
2021-05-10 9:11 ` Andrew Burgess
@ 2021-05-10 13:38 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2021-05-10 13:38 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches
> Date: Mon, 10 May 2021 10:11:24 +0100
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: gdb-patches@sourceware.org
>
> > > -The available watchpoint types represented by constants are defined in the
> > > +The available watchpoint types are represented by constants defined in the
> > > @code{gdb} module:
> > >
> > > @vtable @code
> > > --
> > > 2.25.4
> >
> > Thanks, this is OK.
>
> Thanks for the review. I realised the same mistake was present in the
> guile.texi file too so I extended the patch to cover that file too.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-10 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09 16:29 [PATCH] gdb/doc: reword a sentence Andrew Burgess
2021-05-09 16:54 ` Eli Zaretskii
2021-05-10 9:11 ` Andrew Burgess
2021-05-10 13:38 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).