From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp
Date: Mon, 10 May 2021 17:39:38 +0100 [thread overview]
Message-ID: <20210510163938.GR6612@embecosm.com> (raw)
In-Reply-To: <20210510160152.1398199-1-simon.marchi@polymtl.ca>
* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-05-10 12:01:52 -0400]:
> This test has a little oversight: the test procedure doesn't actually
> use its parameters, the commands and expected patterns are hard-coded,
> so we always test with i386:x86-64, instead of with the three arches.
> Fix that.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.arch/amd64-osabi.exp (test_osabi_none): Use the
> parameters.
LGTM.
Thanks,
Andrew
>
> Change-Id: Iee2c32963d09e502ae791d5df2b6c04a1f49a57a
> ---
> gdb/testsuite/gdb.arch/amd64-osabi.exp | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.arch/amd64-osabi.exp b/gdb/testsuite/gdb.arch/amd64-osabi.exp
> index 0c435893bfd3..151fa35e8e4c 100644
> --- a/gdb/testsuite/gdb.arch/amd64-osabi.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-osabi.exp
> @@ -24,10 +24,10 @@ if { ![istarget x86_64-*-* ] } {
> proc test_osabi_none { arch void_ptr_size long_double_size } {
> clean_restart
>
> - gdb_test "set architecture i386:x86-64" "The target architecture is set to \"i386:x86-64\"\\."
> + gdb_test "set architecture $arch" "The target architecture is set to \"$arch\"\\."
> gdb_test_no_output "set osabi none" "set osabi none"
> - gdb_test "print sizeof (void*)" " = 8"
> - gdb_test "print sizeof (long double)" " = 16"
> + gdb_test "print sizeof (void*)" " = $void_ptr_size"
> + gdb_test "print sizeof (long double)" " = $long_double_size"
> }
>
> set infos { \
> --
> 2.30.1
>
next prev parent reply other threads:[~2021-05-10 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 16:01 Simon Marchi
2021-05-10 16:39 ` Andrew Burgess [this message]
2021-05-10 16:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510163938.GR6612@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).