public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp
@ 2021-05-10 16:01 Simon Marchi
  2021-05-10 16:39 ` Andrew Burgess
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2021-05-10 16:01 UTC (permalink / raw)
  To: gdb-patches

This test has a little oversight: the test procedure doesn't actually
use its parameters, the commands and expected patterns are hard-coded,
so we always test with i386:x86-64, instead of with the three arches.
Fix that.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-osabi.exp (test_osabi_none): Use the
	parameters.

Change-Id: Iee2c32963d09e502ae791d5df2b6c04a1f49a57a
---
 gdb/testsuite/gdb.arch/amd64-osabi.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/amd64-osabi.exp b/gdb/testsuite/gdb.arch/amd64-osabi.exp
index 0c435893bfd3..151fa35e8e4c 100644
--- a/gdb/testsuite/gdb.arch/amd64-osabi.exp
+++ b/gdb/testsuite/gdb.arch/amd64-osabi.exp
@@ -24,10 +24,10 @@ if { ![istarget x86_64-*-* ] } {
 proc test_osabi_none { arch void_ptr_size long_double_size } {
     clean_restart
 
-    gdb_test "set architecture i386:x86-64" "The target architecture is set to \"i386:x86-64\"\\."
+    gdb_test "set architecture $arch" "The target architecture is set to \"$arch\"\\."
     gdb_test_no_output "set osabi none" "set osabi none"
-    gdb_test "print sizeof (void*)" " = 8"
-    gdb_test "print sizeof (long double)" " = 16"
+    gdb_test "print sizeof (void*)" " = $void_ptr_size"
+    gdb_test "print sizeof (long double)" " = $long_double_size"
 }
 
 set infos { \
-- 
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-10 16:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 16:01 [PATCH] gdb/testsuite: use proc parameters in gdb.arch/amd64-osabi.exp Simon Marchi
2021-05-10 16:39 ` Andrew Burgess
2021-05-10 16:44   ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).