public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] New option for 'info sources', also better MI support
Date: Thu, 13 May 2021 11:34:01 +0100	[thread overview]
Message-ID: <20210513103401.GD3067949@embecosm.com> (raw)
In-Reply-To: <cover.1619456691.git.andrew.burgess@embecosm.com>

Ping!

I know I have some doc feedback that I still need to address, but any
code feedback would be great.

Thanks,
Andrew

* Andrew Burgess <andrew.burgess@embecosm.com> [2021-04-26 18:06:59 +0100]:

> Patches #1 and #2 are setup/cleanup, then...
> 
> patch #2 adds a new option to 'info sources' to get a different view
> on the data, and...
> 
> patch #3 extends the existing MI equivalent of 'info sources' making
> it as powerful as the CLI version.
> 
> ---
> 
> Andrew Burgess (4):
>   gdb: add new function quick_symbol_functions::has_unexpanded_symbols
>   gdb: make struct output_source_filename_data more C++ like
>   gdb: add new -group-by-binary flag to info sources command
>   gdb/mi: extend -file-list-exec-source-files command
> 
>  gdb/ChangeLog                                 |  79 ++++
>  gdb/NEWS                                      |  18 +
>  gdb/doc/ChangeLog                             |  10 +
>  gdb/doc/gdb.texinfo                           | 159 ++++++--
>  gdb/dwarf2/read.c                             |  22 ++
>  gdb/mi/mi-cmd-file.c                          |  84 ++--
>  gdb/objfiles.h                                |   6 +
>  gdb/psympriv.h                                |   2 +
>  gdb/psymtab.c                                 |  18 +
>  gdb/quick-symbol.h                            |   6 +
>  gdb/symfile-debug.c                           |  13 +
>  gdb/symtab.c                                  | 361 ++++++++++++------
>  gdb/symtab.h                                  |  24 ++
>  gdb/testsuite/ChangeLog                       |  16 +
>  gdb/testsuite/gdb.base/info_sources.exp       |   5 +
>  .../gdb.base/info_sources_2-header.h          |  28 ++
>  gdb/testsuite/gdb.base/info_sources_2-lib.c   |  25 ++
>  gdb/testsuite/gdb.base/info_sources_2-test.c  |  26 ++
>  gdb/testsuite/gdb.base/info_sources_2.exp     | 169 ++++++++
>  gdb/testsuite/gdb.dwarf2/dw2-filename.exp     |   2 +-
>  gdb/testsuite/gdb.mi/mi-file.exp              |   2 +-
>  gdb/testsuite/gdb.mi/mi-info-sources-base.c   |  24 ++
>  gdb/testsuite/gdb.mi/mi-info-sources.c        |  25 ++
>  gdb/testsuite/gdb.mi/mi-info-sources.exp      | 177 +++++++++
>  24 files changed, 1127 insertions(+), 174 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c
>  create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c
>  create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp
> 
> -- 
> 2.25.4
> 

  parent reply	other threads:[~2021-05-13 10:34 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 17:06 Andrew Burgess
2021-04-26 17:07 ` [PATCH 1/4] gdb: add new function quick_symbol_functions::has_unexpanded_symbols Andrew Burgess
2021-05-13 14:38   ` Simon Marchi
2021-05-13 17:29     ` Tom Tromey
2021-05-13 14:46   ` Simon Marchi
2021-04-26 17:07 ` [PATCH 2/4] gdb: make struct output_source_filename_data more C++ like Andrew Burgess
2021-05-13 14:58   ` Simon Marchi
2021-04-26 17:07 ` [PATCH 3/4] gdb: add new -group-by-binary flag to info sources command Andrew Burgess
2021-04-26 17:34   ` Eli Zaretskii
2021-05-13 15:05   ` Simon Marchi
2021-05-15  8:45     ` Andrew Burgess
2021-05-15 13:19       ` Simon Marchi
2021-04-26 17:07 ` [PATCH 4/4] gdb/mi: extend -file-list-exec-source-files command Andrew Burgess
2021-04-26 17:39   ` Eli Zaretskii
2021-05-13 15:47   ` Simon Marchi
2021-05-13 10:34 ` Andrew Burgess [this message]
2021-05-19 11:12 ` [PATCHv2 0/5] "info sources" - group by objfile Andrew Burgess
2021-05-19 11:12   ` [PATCHv2 1/5] gdb: add new function quick_symbol_functions::has_unexpanded_symbols Andrew Burgess
2021-05-19 11:12   ` [PATCHv2 2/5] gdb: make struct output_source_filename_data more C++ like Andrew Burgess
2021-05-19 11:12   ` [PATCHv2 3/5] gdb/mi: add regexp filtering to -file-list-exec-source-files Andrew Burgess
2021-05-19 11:51     ` Eli Zaretskii
2021-05-19 11:12   ` [PATCHv2 4/5] gdb/mi: add new --group-by-objfile flag for -file-list-exec-source-files Andrew Burgess
2021-05-19 11:44     ` Eli Zaretskii
2021-05-19 11:12   ` [PATCHv2 5/5] gdb: change info sources to group results by objfile Andrew Burgess
2021-05-19 11:53     ` Eli Zaretskii
2021-06-03 13:08     ` Simon Marchi
2021-06-03  9:27   ` [PATCHv2 0/5] "info sources" - group " Andrew Burgess
2021-06-03 13:15     ` Simon Marchi
2021-06-07 18:32   ` [PATCHv3 " Andrew Burgess
2021-06-07 18:32     ` [PATCHv3 1/5] gdb: add new function quick_symbol_functions::has_unexpanded_symbols Andrew Burgess
2021-06-07 18:32     ` [PATCHv3 2/5] gdb: make struct output_source_filename_data more C++ like Andrew Burgess
2021-07-05 12:31       ` Tom de Vries
2021-07-26 13:21         ` Andrew Burgess
2021-06-07 18:32     ` [PATCHv3 3/5] gdb/mi: add regexp filtering to -file-list-exec-source-files Andrew Burgess
2021-06-07 18:32     ` [PATCHv3 4/5] gdb/mi: add new --group-by-objfile flag for -file-list-exec-source-files Andrew Burgess
2021-06-07 18:32     ` [PATCHv3 5/5] gdb: change info sources to group results by objfile Andrew Burgess
2021-06-21 12:02     ` PING! Re: [PATCHv3 0/5] "info sources" - group " Andrew Burgess
2021-06-25 20:08       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513103401.GD3067949@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).