From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 8F9D6385703F for ; Thu, 13 May 2021 10:34:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F9D6385703F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42b.google.com with SMTP id x5so26422219wrv.13 for ; Thu, 13 May 2021 03:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8lHrtOYELfy09CiJOfO/PdK+TRZksVyarfxq9DltDqo=; b=QOLvZ0TgUEzY0/7MGgRpSAuspYZrgGW7dlZbaCQ9EJ5D3Q0I4oMMfJNcvn4FEdQ+nk HOJkIOSGPmMrPLF2G2X7eiqtBUqp5WUCgnw2u+oMtfaspVGInhLNJ4A8vJZmtORbY8tD mCK2elBNrSMmplqMFva2o4Gdn58DKgBKgsgOnDKmDEP1ElHt9k6OcFQZWsYkjQGU/VTD K6q3NcuJNRvH024Tm3ieXhO5q4Of/2GlUe3BLnsiCXNK1DYLWd7XHsTQKspWJzRMD/S6 jhMoYq0GyRgPC7/LEwCV6MA72HmwSq0RjT7i9U4e7hnHQgyZx9Z66vQzb3B1HuhNrxo4 ILEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8lHrtOYELfy09CiJOfO/PdK+TRZksVyarfxq9DltDqo=; b=Twml9w6imAQnR7F8LfpTvdi5CublhsOm64L1/vHNC6k6NaM4XIOnZup7ZJ2jXWUo2b b2jjTRfeyoCESgqvPKvOSAbNeQJVBBq3b9XL3aFLoJsoxXQV1UvovupNyA7xMdDCM/d6 Jg25Xqj1FJGiJ7CxKZttswS+Gzxfj0e3A0rfDvgz7840I0ZNrHx/z76loXGpa+Na1j0N VqbYEy0EMSrvDocoB0pjvbNw+5LdV0/l5DUHNdjnpJ4FDY+j7DOfetF9DpQnxAzFOf9e /RtFRevRTD1PM3Fno+T67P9lB17+xrVOf7HoFozZpfBw4RMn5JDaLAIjadwJEu4+Pc3k 1W1Q== X-Gm-Message-State: AOAM533zdgwDTq1QD2RFBWOBcooqPAfOf0a7eIQq9H6qm8wBqmhgokCd ELPOipjdxgEiD1edTRT3xdqcRr0wgR2gTw== X-Google-Smtp-Source: ABdhPJwjVDnd3i4y0cakH/2yUd7e3ahhw5uKx5ZiwkbS5KVmaXD+i+XJ31I+mLyVO7QmXlNAVpNyig== X-Received: by 2002:a5d:6484:: with SMTP id o4mr49554484wri.8.1620902043354; Thu, 13 May 2021 03:34:03 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id u5sm2453995wrt.38.2021.05.13.03.34.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 03:34:02 -0700 (PDT) Date: Thu, 13 May 2021 11:34:01 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] New option for 'info sources', also better MI support Message-ID: <20210513103401.GD3067949@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 11:33:20 up 9 days, 23:27, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 10:34:06 -0000 Ping! I know I have some doc feedback that I still need to address, but any code feedback would be great. Thanks, Andrew * Andrew Burgess [2021-04-26 18:06:59 +0100]: > Patches #1 and #2 are setup/cleanup, then... > > patch #2 adds a new option to 'info sources' to get a different view > on the data, and... > > patch #3 extends the existing MI equivalent of 'info sources' making > it as powerful as the CLI version. > > --- > > Andrew Burgess (4): > gdb: add new function quick_symbol_functions::has_unexpanded_symbols > gdb: make struct output_source_filename_data more C++ like > gdb: add new -group-by-binary flag to info sources command > gdb/mi: extend -file-list-exec-source-files command > > gdb/ChangeLog | 79 ++++ > gdb/NEWS | 18 + > gdb/doc/ChangeLog | 10 + > gdb/doc/gdb.texinfo | 159 ++++++-- > gdb/dwarf2/read.c | 22 ++ > gdb/mi/mi-cmd-file.c | 84 ++-- > gdb/objfiles.h | 6 + > gdb/psympriv.h | 2 + > gdb/psymtab.c | 18 + > gdb/quick-symbol.h | 6 + > gdb/symfile-debug.c | 13 + > gdb/symtab.c | 361 ++++++++++++------ > gdb/symtab.h | 24 ++ > gdb/testsuite/ChangeLog | 16 + > gdb/testsuite/gdb.base/info_sources.exp | 5 + > .../gdb.base/info_sources_2-header.h | 28 ++ > gdb/testsuite/gdb.base/info_sources_2-lib.c | 25 ++ > gdb/testsuite/gdb.base/info_sources_2-test.c | 26 ++ > gdb/testsuite/gdb.base/info_sources_2.exp | 169 ++++++++ > gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 2 +- > gdb/testsuite/gdb.mi/mi-file.exp | 2 +- > gdb/testsuite/gdb.mi/mi-info-sources-base.c | 24 ++ > gdb/testsuite/gdb.mi/mi-info-sources.c | 25 ++ > gdb/testsuite/gdb.mi/mi-info-sources.exp | 177 +++++++++ > 24 files changed, 1127 insertions(+), 174 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp > > -- > 2.25.4 >