From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] sim/d10v: Use offsetof in a static assertion about structure layout.
Date: Wed, 19 May 2021 10:45:37 -0700 [thread overview]
Message-ID: <20210519174537.17278-1-jhb@FreeBSD.org> (raw)
clang 11 fails to compile the static assertion as it cannot compute
the pointer value at a compile time:
gdb/sim/d10v/interp.c:1149:37: error: static_assert expression is not an integral constant expression
static_assert ((uintptr_t) &State == (uintptr_t) &State.regs,
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Instead, assert that the offset of State.regs is 0.
sim/d10v/ChangeLog:
* interp.c (sim_create_inferior): Use offsetof in static
assertion.
---
sim/d10v/ChangeLog | 5 +++++
sim/d10v/interp.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/sim/d10v/ChangeLog b/sim/d10v/ChangeLog
index e45bd3833b0..d799d238db9 100644
--- a/sim/d10v/ChangeLog
+++ b/sim/d10v/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-19 John Baldwin <jhb@FreeBSD.org>
+
+ * interp.c (sim_create_inferior): Use offsetof in static
+ assertion.
+
2021-05-17 Mike Frysinger <vapier@gentoo.org>
* sim-main.h (SIM_HAVE_COMMON_SIM_STATE): Delete.
diff --git a/sim/d10v/interp.c b/sim/d10v/interp.c
index b56b204c72d..ee242f766f6 100644
--- a/sim/d10v/interp.c
+++ b/sim/d10v/interp.c
@@ -1146,8 +1146,8 @@ sim_create_inferior (SIM_DESC sd, struct bfd *abfd,
bfd_vma start_address;
/* Make sure we have the right structure for the following memset. */
- static_assert ((uintptr_t) &State == (uintptr_t) &State.regs,
- "&State != &State.regs");
+ static_assert (offsetof(typeof(State), regs) == 0,
+ "State.regs is not at offset 0");
/* Reset state from the regs field until the mem field. */
memset (&State, 0, (uintptr_t) &State.mem - (uintptr_t) &State.regs);
--
2.31.1
next reply other threads:[~2021-05-19 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 17:45 John Baldwin [this message]
2021-05-19 23:35 ` Mike Frysinger
2021-05-21 17:46 ` John Baldwin
2021-05-21 22:39 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519174537.17278-1-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).