From: Hans-Peter Nilsson <hp@axis.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: <binutils@sourceware.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] opcodes: cris: move desc & opc files from sim/
Date: Thu, 20 May 2021 01:48:27 +0200 [thread overview]
Message-ID: <20210519234827.86E7C203C6@pchp3.se.axis.com> (raw)
In-Reply-To: <YKWhkimTv9ZZgQif@vapier> (message from Mike Frysinger on Thu, 20 May 2021 01:38:58 +0200)
> From: Mike Frysinger <vapier@gentoo.org>
> Date: Thu, 20 May 2021 01:38:58 +0200
> On 19 May 2021 23:32, Hans-Peter Nilsson wrote:
> > > From: Hans-Peter Nilsson <Hans-Peter.Nilsson@axis.com>
> > > Date: Wed, 19 May 2021 23:26:26 +0200
> >
> > > > From: Mike Frysinger via Binutils <binutils@sourceware.org>
> > > > Date: Wed, 19 May 2021 18:21:07 +0200
> > >
> > > > All other cgen ports keep their desc & opc files under opcodes/, so
> > > > move the cris files over too. The cris-opc.c file is already here.
> > >
> > > Unline (most) other CGEN ports, the assembler and
> > > disassembler isn't generated from the CGEN description. But
> > > that's not a reason to keep it different in this regard.
> > >
> > > Ok with the appropriate opcodes/ChangeLog entry. Thanks!
> >
> > No, wait, NOT ok: cris-opc.c isn't CGEN-generated. Please
> > fix so it isn't "regenerated".
>
> you want me to delete the cris cgen rule entirely ?
"No" if you mean removing the regeneration rule for the
CGEN-generated CRIS files of course.
But, if you want to move the CRIS CGEN files to opcodes/,
there must be precautions to not overwrite the cris-opc.c
there.
brgds, H-P
next prev parent reply other threads:[~2021-05-19 23:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 1:56 Mike Frysinger
2021-05-19 14:52 ` Andrew Burgess
2021-05-19 16:21 ` Mike Frysinger
2021-05-19 16:21 ` Mike Frysinger
2021-05-19 21:26 ` Hans-Peter Nilsson
2021-05-19 21:32 ` Hans-Peter Nilsson
2021-05-19 23:38 ` Mike Frysinger
2021-05-19 23:48 ` Hans-Peter Nilsson [this message]
2021-05-20 5:18 ` Mike Frysinger
2021-05-20 13:21 ` Hans-Peter Nilsson
2021-05-23 3:55 ` Mike Frysinger
2021-05-23 4:12 ` [PATCH v2] " Mike Frysinger
2021-05-23 20:52 ` Hans-Peter Nilsson
2021-05-23 21:01 ` Hans-Peter Nilsson
2021-05-24 1:23 ` Mike Frysinger
2021-05-24 1:23 ` [PATCH v3] " Mike Frysinger
2021-05-24 1:43 ` Hans-Peter Nilsson
2021-05-24 3:48 ` Mike Frysinger
2021-05-24 3:46 ` [PATCH v4] " Mike Frysinger
2021-05-24 13:24 ` Hans-Peter Nilsson
2021-05-25 10:13 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519234827.86E7C203C6@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).