From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id AB9B53848031 for ; Mon, 24 May 2021 03:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AB9B53848031 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 0422B340834 for ; Mon, 24 May 2021 03:43:57 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed] sim: cris: fix memory setup typos Date: Sun, 23 May 2021 23:43:55 -0400 Message-Id: <20210524034355.19969-1-vapier@gentoo.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 03:44:00 -0000 The cleanup to use BFD_VMA_FMT also adjusted this line, but used the incorrect format: while BFD_VMA_FMT needs an explicit "x", PRIx32 does not, so the spurious "x" here confused the parser and broke execution. --- sim/cris/ChangeLog | 4 ++++ sim/cris/sim-if.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/sim/cris/ChangeLog b/sim/cris/ChangeLog index 1b4a5fe33662..4e7b919a3c50 100644 --- a/sim/cris/ChangeLog +++ b/sim/cris/ChangeLog @@ -1,3 +1,7 @@ +2021-05-23 Mike Frysinger + + * sim-if.c (sim_open): Delete "x" after PRI macros. + 2021-05-23 Mike Frysinger * sim-if.c: Include unistd.h. diff --git a/sim/cris/sim-if.c b/sim/cris/sim-if.c index cea499d1daa9..6613a93ecc55 100644 --- a/sim/cris/sim-if.c +++ b/sim/cris/sim-if.c @@ -879,7 +879,7 @@ sim_open (SIM_OPEN_KIND kind, host_callback *callback, struct bfd *abfd, /* Allocate core managed memory if none specified by user. */ if (sim_core_read_buffer (sd, NULL, read_map, &c, startmem, 1) == 0) - sim_do_commandf (sd, "memory region 0x%" PRIx32 "x,0x%" PRIu32 "x", + sim_do_commandf (sd, "memory region 0x%" PRIx32 ",0x%" PRIu32, startmem, endmem - startmem); /* Allocate simulator I/O managed memory if none specified by user. */ -- 2.31.1