From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 2/5] Always build 'all' in gdb/testsuite
Date: Fri, 28 May 2021 13:27:40 -0600 [thread overview]
Message-ID: <20210528192743.508390-3-tromey@adacore.com> (raw)
In-Reply-To: <20210528192743.508390-1-tromey@adacore.com>
gdb's Makefile currently excludes testsuite from the subdirectories to
build. I don't think there's a good reason for this, so this patch
adds testsuite to the SUBDIRS list and removes a special case from
'all'.
2021-05-28 Tom Tromey <tromey@adacore.com>
* Makefile.in (SUBDIRS): Add testsuite.
(all): Don't exclude testsuite.
---
gdb/ChangeLog | 5 +++++
gdb/Makefile.in | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index bb6c5dfa784..06c2da5dcf8 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1590,7 +1590,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $(YYOBJ) \
$(SUBDIR_TARGET_OBS) \
$(SUBDIR_GCC_COMPILE_OBS)
-SUBDIRS = doc @subdirs@ data-directory
+SUBDIRS = doc @subdirs@ data-directory testsuite
CLEANDIRS = $(SUBDIRS)
# List of subdirectories in the build tree that must exist.
@@ -1632,7 +1632,7 @@ generated_files = \
PYTHON_CFLAGS = @PYTHON_CFLAGS@
all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb
- @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=`echo $(SUBDIRS) | sed 's/testsuite//'`" subdir_do
+ @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=$(SUBDIRS)" subdir_do
# Rule for compiling .c files in the top-level gdb directory.
# The order-only dependencies ensure that we create the build subdirectories.
--
2.26.3
next prev parent reply other threads:[~2021-05-28 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 19:27 [PATCH 0/5] Some gdb build cleanups Tom Tromey
2021-05-28 19:27 ` [PATCH 1/5] Remove gdb/testsuite/configure Tom Tromey
2021-05-29 3:44 ` Simon Marchi
2021-06-01 13:59 ` Tom Tromey
2021-06-05 9:51 ` Tom de Vries
2021-06-09 14:35 ` Tom Tromey
2021-06-09 14:46 ` Tom de Vries
2021-08-07 1:03 ` Tom de Vries
2021-05-28 19:27 ` Tom Tromey [this message]
2021-05-28 19:27 ` [PATCH 3/5] Apply silent Makefile rules to gdb/testsuite Tom Tromey
2021-05-28 19:27 ` [PATCH 4/5] Clean up gdb's --enable-shared Tom Tromey
2021-05-28 19:27 ` [PATCH 5/5] Remove some gdb/data-directory special cases Tom Tromey
2021-05-29 3:50 ` [PATCH 0/5] Some gdb build cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528192743.508390-3-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).