From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 5/5] Remove some gdb/data-directory special cases
Date: Fri, 28 May 2021 13:27:43 -0600 [thread overview]
Message-ID: <20210528192743.508390-6-tromey@adacore.com> (raw)
In-Reply-To: <20210528192743.508390-1-tromey@adacore.com>
I found an odd special case for data-directory in gdb's Makefile. I
don't see a reason to have this, so this removes it in favor of having
this code work in the most ordinary way for a subdirectory build.
gdb/ChangeLog
2021-05-28 Tom Tromey <tromey@adacore.com>
* Makefile.in (all-data-directory): Remove.
(data-directory/Makefile): Remove.
---
gdb/ChangeLog | 5 +++++
gdb/Makefile.in | 8 --------
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 06c2da5dcf8..d76cbf235b8 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1885,11 +1885,6 @@ ifneq ($(CODESIGN_CERT),)
$(ECHO_SIGN) $(CODESIGN) -s $(CODESIGN_CERT) gdb$(EXEEXT)
endif
-# Convenience rule to handle recursion.
-.PHONY: all-data-directory
-all-data-directory: data-directory/Makefile
- @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=data-directory subdir_do
-
# This is useful when debugging GDB, because some Unix's don't let you run GDB
# on itself without copying the executable. So "make gdb1" will make
# gdb and put a copy in gdb1, and you can run it with "gdb gdb1".
@@ -1989,9 +1984,6 @@ subdir_do: force
Makefile: Makefile.in config.status
$(SHELL) config.status $@
-data-directory/Makefile: data-directory/Makefile.in config.status
- $(SHELL) config.status $@
-
.PHONY: run
run: Makefile
./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS)
--
2.26.3
next prev parent reply other threads:[~2021-05-28 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 19:27 [PATCH 0/5] Some gdb build cleanups Tom Tromey
2021-05-28 19:27 ` [PATCH 1/5] Remove gdb/testsuite/configure Tom Tromey
2021-05-29 3:44 ` Simon Marchi
2021-06-01 13:59 ` Tom Tromey
2021-06-05 9:51 ` Tom de Vries
2021-06-09 14:35 ` Tom Tromey
2021-06-09 14:46 ` Tom de Vries
2021-08-07 1:03 ` Tom de Vries
2021-05-28 19:27 ` [PATCH 2/5] Always build 'all' in gdb/testsuite Tom Tromey
2021-05-28 19:27 ` [PATCH 3/5] Apply silent Makefile rules to gdb/testsuite Tom Tromey
2021-05-28 19:27 ` [PATCH 4/5] Clean up gdb's --enable-shared Tom Tromey
2021-05-28 19:27 ` Tom Tromey [this message]
2021-05-29 3:50 ` [PATCH 0/5] Some gdb build cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528192743.508390-6-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).