From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed] sim: v850: add pointer casts for execv on Windows
Date: Sat, 29 May 2021 15:33:10 -0400 [thread overview]
Message-ID: <20210529193310.8710-1-vapier@gentoo.org> (raw)
The execv prototypes on Windows via mingw64 include extra const
markings on the argv/envp pointers than what POSIX specifies.
Cast them to void* as a hack to get it working on all platforms.
---
sim/v850/ChangeLog | 4 ++++
sim/v850/simops.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/sim/v850/ChangeLog b/sim/v850/ChangeLog
index 02e6bbdc2158..29237d80c985 100644
--- a/sim/v850/ChangeLog
+++ b/sim/v850/ChangeLog
@@ -1,3 +1,7 @@
+2021-05-29 Mike Frysinger <vapier@gentoo.org>
+
+ * simops.c (OP_10007E0): Add (void*) casts to argv & envp.
+
2021-05-17 Mike Frysinger <vapier@gentoo.org>
* sim-main.h (SIM_HAVE_COMMON_SIM_STATE): Delete.
diff --git a/sim/v850/simops.c b/sim/v850/simops.c
index 62a2bbcbb615..f0e2745dee93 100644
--- a/sim/v850/simops.c
+++ b/sim/v850/simops.c
@@ -1640,7 +1640,7 @@ OP_10007E0 (void)
char *path = fetch_str (simulator, PARM1);
char **argv = fetch_argv (simulator, PARM2);
char **envp = fetch_argv (simulator, PARM3);
- RETVAL = execve (path, argv, envp);
+ RETVAL = execve (path, (void *)argv, (void *)envp);
free (path);
freeargv (argv);
freeargv (envp);
@@ -1656,7 +1656,7 @@ OP_10007E0 (void)
{
char *path = fetch_str (simulator, PARM1);
char **argv = fetch_argv (simulator, PARM2);
- RETVAL = execv (path, argv);
+ RETVAL = execv (path, (void *)argv);
free (path);
freeargv (argv);
RETERR = errno;
--
2.31.1
reply other threads:[~2021-05-29 19:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210529193310.8710-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).