From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 1DA223857C75 for ; Thu, 3 Jun 2021 17:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DA223857C75 Received: by mail-ej1-x62f.google.com with SMTP id g8so10519144ejx.1 for ; Thu, 03 Jun 2021 10:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XioSC+f0fWxHQnjMvxOX1nb5oA11BBpcSxKdXZBKmkE=; b=s7BQtw19CZ8MscwcD0rEOt9YpgTg+hF8n3cpHXn3doB2nL5IddsEMZNEO7eM53rTol UktNVyyY/abS/8hUOaVL/z3UicoMy7wGMUxs6Qhiz5RMFlNNZxhbzPTD26OVl4WwAWZc 5Q0HlyySbry59GMWR5XNglHmE23f3q+uHUnwJ22eTXiVZeJrDw/odbaVrMHGKR3LK7pv F582OTdSOqyWkOE/Czsqn23Pp45EyF8duvX1HVnr8Tzkm17FexBZ/c26x6lAC682boiO +fFDhtv7foIeFVfQZddy41ypnO3zg6FfYrqwqsVpYNkbhT9TW2GkKUa64dnoP38dMlm1 NtzQ== X-Gm-Message-State: AOAM533Or6ZaBBJ/B8tJVxbLIqoxJjuMUmWD273ju1rJQMhrI+6phRVg WC366D+ZgQhTQ5fUAfDZxYV3pOmiPEo= X-Google-Smtp-Source: ABdhPJyJ/oMrc/h2rdPLo+GYXv28RGYP39I9hAMuxfRkWXicU0BThm9pcIktNr6jV4E/41XXCIPbSA== X-Received: by 2002:a17:906:8482:: with SMTP id m2mr491526ejx.314.1622742167034; Thu, 03 Jun 2021 10:42:47 -0700 (PDT) Received: from atlantis.fritz.box ([2001:983:21dc:1:fc9:f284:50db:dc0e]) by smtp.gmail.com with ESMTPSA id l11sm1761004ejd.103.2021.06.03.10.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 10:42:46 -0700 (PDT) From: Shahab Vahedi To: gdb-patches@sourceware.org Cc: Shahab Vahedi , Shahab Vahedi , Francois Bedard Subject: [PATCH] arc: Add 'set disassembler-options' support Date: Thu, 3 Jun 2021 19:42:47 +0200 Message-Id: <20210603174247.6999-1-shahab.vahedi@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2021 17:42:50 -0000 From: Shahab Vahedi Implement ARC target support for passing options to the disassembler through the command interface. e.g.: gdb> set disassembler-options cpu=hs38_linux ... gdb/ChangeLog: * NEWS: Document 'set disassembler-options' support for the ARC target. * arc-tdep.c (arc_gdbarch_init): Set 'gdbarch_valid_disassembler_options'. gdb/doc/ChangeLog: * gdb.texinfo (Source and Machine Code): Document 'set disassembler-options' support for the ARC target. gdb/testsuite/ChangeLog: * gdb.arch/arc-disassembler-options.exp: New test. * gdb.arch/arc-disassembler-options.s: New test source. --- gdb/NEWS | 3 ++ gdb/arc-tdep.c | 6 ++- gdb/doc/gdb.texinfo | 4 +- .../gdb.arch/arc-disassembler-options.exp | 44 +++++++++++++++++++ .../gdb.arch/arc-disassembler-options.s | 21 +++++++++ 5 files changed, 74 insertions(+), 4 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.exp create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.s diff --git a/gdb/NEWS b/gdb/NEWS index 19cb444e7fe..54477b48331 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,9 @@ *** Changes since GDB 10 +* The 'set disassembler-options' command now supports specifying options + for the ARC target. + * GDB now supports general memory tagging functionality if the underlying architecture supports the proper primitives and hooks. Currently this is enabled only for AArch64 MTE. diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c index 1a862d969ca..4083816726d 100644 --- a/gdb/arc-tdep.c +++ b/gdb/arc-tdep.c @@ -2457,11 +2457,13 @@ arc_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) arc_disassembler_options = NULL; break; } - set_gdbarch_disassembler_options (gdbarch, - &arc_disassembler_options); } } + set_gdbarch_disassembler_options (gdbarch, &arc_disassembler_options); + set_gdbarch_valid_disassembler_options (gdbarch, + disassembler_options_arc ()); + tdesc_use_registers (gdbarch, tdesc, std::move (tdesc_data)); return gdbarch; diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 5049c55c6b1..4730157c165 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -9882,8 +9882,8 @@ The default value is the empty string. If it is necessary to specify more than one disassembler option, then multiple options can be placed together into a comma separated list. -Currently this command is only supported on targets ARM, MIPS, PowerPC -and S/390. +Currently this command is only supported on targets ARC, ARM, MIPS, +PowerPC and S/390. @kindex show disassembler-options @item show disassembler-options diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp new file mode 100644 index 00000000000..cab713c1cb3 --- /dev/null +++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp @@ -0,0 +1,44 @@ +# Copyright 2021 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test ARC disassembler options. + +if { ![istarget "arc-*-*"] } then { + verbose "Skipping ARC disassembler option test." + return +} + +standard_testfile .s +set objfile [standard_output_file ${testfile}.o] + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \ + != "" } { + return +} + +clean_restart ${objfile} + +proc arc_disassemble_test { func insn mesg } { + gdb_test "disassemble $func" \ + "Dump of assembler code for function $func:\r\n\[^:\]+:\t$insn\r\nEnd of assembler dump\." \ + $mesg +} + +# Verify defaults. +arc_disassemble_test foo "lr\tr0,\\\[tlbpd0\\\]" "disassemble default" + +# Verify option overrides. +gdb_test "set disassembler-options cpu=arcem" +arc_disassemble_test foo "lr\tr0,\\\[1120\\\]" "disassemble cpu=arcem" diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.s b/gdb/testsuite/gdb.arch/arc-disassembler-options.s new file mode 100644 index 00000000000..9f64ce43a43 --- /dev/null +++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.s @@ -0,0 +1,21 @@ +# This test is part of GDB, the GNU debugger. +# +# Copyright 2021 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +.globl foo +foo: + lr r0, [tlbpd0] +.end foo -- 2.31.1