From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 2B616388E810 for ; Fri, 4 Jun 2021 07:38:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B616388E810 Received: by mail-ed1-x531.google.com with SMTP id r11so9985365edt.13 for ; Fri, 04 Jun 2021 00:38:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lclhD2MuPm6gNjTonEU+bqT/y94pl6tLmRQE1yk5qTk=; b=FKL/dBUE8zswNPncmG0ZU1C0Nyy1vwQ1cnm/j1JSf5Rdi2Me0YXwNMI8vNWj/BMzl2 4Rwic+yFYNQtHtniWoxmAUD6pxnIxtEdYKDZSzA00C2JK2pqEQ3Y8RqcNizSg2mQwn0E dsYtjwHjTp9cPbc1vcRXmbzIEeyBilpcr1yGn0P3fyqVgR6iLksPBXIeM4Jw99x+Di5e G2kxHdMsA7C3srC1e84rQwQCy64kvJ5+Wonl94piYOFLK9nmaiRg7IyUaS49J1zxESrl E71vXLqLsBgM2Zma+ubgXIrUQsjQROeJlFJ/jpE6BVIMnfKpvWlSRmZFcIIxlmffzaRl LyxQ== X-Gm-Message-State: AOAM5332HDJ8g7rYHfz95HDUF0TeixMm+/iYBjQzOltZAp/8Q9JjKaWQ Nm2wHAFKUZMoftPjJnc3luwXuyU6ALU= X-Google-Smtp-Source: ABdhPJz4vhDNA2qZWIcBaOtJepJ9cjvBhGanhyoa2sbz/2FNMbC/D/o9C79sToF8Kk6PlR9gIaf8Cg== X-Received: by 2002:aa7:c450:: with SMTP id n16mr3344019edr.386.1622792337046; Fri, 04 Jun 2021 00:38:57 -0700 (PDT) Received: from atlantis.fritz.box ([2001:983:21dc:1:fc9:f284:50db:dc0e]) by smtp.gmail.com with ESMTPSA id r19sm2827628eds.75.2021.06.04.00.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 00:38:56 -0700 (PDT) From: Shahab Vahedi To: gdb-patches@sourceware.org Cc: Shahab Vahedi , Shahab Vahedi , Eli Zaretskii , Francois Bedard Subject: [PATCH v2] arc: Add 'set disassembler-options' support Date: Fri, 4 Jun 2021 09:38:34 +0200 Message-Id: <20210604073833.5411-1-shahab.vahedi@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210603174247.6999-1-shahab.vahedi@gmail.com> References: <20210603174247.6999-1-shahab.vahedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 07:39:00 -0000 From: Shahab Vahedi Implement ARC target support for passing options to the disassembler through the command interface. e.g.: gdb> set disassembler-options cpu=hs38_linux ... v2: - break the long line in the test (arc_disassemble_test {}). gdb/ChangeLog: * NEWS: Document 'set disassembler-options' support for the ARC target. * arc-tdep.c (arc_gdbarch_init): Set 'gdbarch_valid_disassembler_options'. gdb/doc/ChangeLog: * gdb.texinfo (Source and Machine Code): Document 'set disassembler-options' support for the ARC target. gdb/testsuite/ChangeLog: * gdb.arch/arc-disassembler-options.exp: New test. * gdb.arch/arc-disassembler-options.s: New test source. --- gdb/NEWS | 3 ++ gdb/arc-tdep.c | 6 ++- gdb/doc/gdb.texinfo | 4 +- .../gdb.arch/arc-disassembler-options.exp | 45 +++++++++++++++++++ .../gdb.arch/arc-disassembler-options.s | 21 +++++++++ 5 files changed, 75 insertions(+), 4 deletions(-) create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.exp create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.s diff --git a/gdb/NEWS b/gdb/NEWS index ab678acec8b..56743fc9aea 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,9 @@ *** Changes since GDB 10 +* The 'set disassembler-options' command now supports specifying options + for the ARC target. + * GDB now supports general memory tagging functionality if the underlying architecture supports the proper primitives and hooks. Currently this is enabled only for AArch64 MTE. diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c index ece802545c0..3afbf4264fe 100644 --- a/gdb/arc-tdep.c +++ b/gdb/arc-tdep.c @@ -2434,11 +2434,13 @@ arc_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) arc_disassembler_options = NULL; break; } - set_gdbarch_disassembler_options (gdbarch, - &arc_disassembler_options); } } + set_gdbarch_disassembler_options (gdbarch, &arc_disassembler_options); + set_gdbarch_valid_disassembler_options (gdbarch, + disassembler_options_arc ()); + tdesc_use_registers (gdbarch, tdesc, std::move (tdesc_data)); return gdbarch; diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 90d827a50e7..d09b86cda95 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -9879,8 +9879,8 @@ The default value is the empty string. If it is necessary to specify more than one disassembler option, then multiple options can be placed together into a comma separated list. -Currently this command is only supported on targets ARM, MIPS, PowerPC -and S/390. +Currently this command is only supported on targets ARC, ARM, MIPS, +PowerPC and S/390. @kindex show disassembler-options @item show disassembler-options diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp new file mode 100644 index 00000000000..6bfe06b3d9d --- /dev/null +++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp @@ -0,0 +1,45 @@ +# Copyright 2021 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test ARC disassembler options. + +if { ![istarget "arc-*-*"] } then { + verbose "Skipping ARC disassembler option test." + return +} + +standard_testfile .s +set objfile [standard_output_file ${testfile}.o] + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \ + != "" } { + return +} + +clean_restart ${objfile} + +proc arc_disassemble_test { func insn mesg } { + gdb_test "disassemble $func" \ + "Dump of assembler code for function $func:\r\n\ + \[^:\]+:\t$insn\r\nEnd of assembler dump\." \ + $mesg +} + +# Verify defaults. +arc_disassemble_test foo "lr\tr0,\\\[tlbpd0\\\]" "disassemble default" + +# Verify option overrides. +gdb_test "set disassembler-options cpu=arcem" +arc_disassemble_test foo "lr\tr0,\\\[1120\\\]" "disassemble cpu=arcem" diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.s b/gdb/testsuite/gdb.arch/arc-disassembler-options.s new file mode 100644 index 00000000000..9f64ce43a43 --- /dev/null +++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.s @@ -0,0 +1,21 @@ +# This test is part of GDB, the GNU debugger. +# +# Copyright 2021 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +.globl foo +foo: + lr r0, [tlbpd0] +.end foo -- 2.31.1