From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: gdb-patches@sourceware.org
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>, Eli Zaretskii <eliz@gnu.org>,
Tom Tromey <tom@tromey.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: [PUSHED] arc: Add 'set disassembler-options' support
Date: Sat, 5 Jun 2021 11:50:02 +0200 [thread overview]
Message-ID: <20210605095002.11338-1-shahab.vahedi@gmail.com> (raw)
In-Reply-To: <20210603174247.6999-1-shahab.vahedi@gmail.com>
From: Shahab Vahedi <shahab@synopsys.com>
Implement ARC target support for passing options to the disassembler
through the command interface. e.g.:
gdb> set disassembler-options cpu=hs38_linux ...
gdb/ChangeLog:
* NEWS: Document 'set disassembler-options' support for the ARC
target.
* arc-tdep.c (arc_gdbarch_init): Set
'gdbarch_valid_disassembler_options'.
gdb/doc/ChangeLog:
* gdb.texinfo (Source and Machine Code): Document 'set
disassembler-options' support for the ARC target.
gdb/testsuite/ChangeLog:
* gdb.arch/arc-disassembler-options.exp: New test.
* gdb.arch/arc-disassembler-options.s: New test source.
---
gdb/ChangeLog | 7 +++
gdb/NEWS | 3 ++
gdb/arc-tdep.c | 6 ++-
gdb/doc/ChangeLog | 5 +++
gdb/doc/gdb.texinfo | 4 +-
gdb/testsuite/ChangeLog | 5 +++
.../gdb.arch/arc-disassembler-options.exp | 45 +++++++++++++++++++
.../gdb.arch/arc-disassembler-options.s | 21 +++++++++
8 files changed, 92 insertions(+), 4 deletions(-)
create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.exp
create mode 100644 gdb/testsuite/gdb.arch/arc-disassembler-options.s
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8ebb552123f..9fc2310d144 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2021-06-05 Shahab Vahedi <shahab@synopsys.com>
+
+ * NEWS: Document 'set disassembler-options' support for the ARC
+ target.
+ * arc-tdep.c (arc_gdbarch_init): Set
+ 'gdbarch_valid_disassembler_options'.
+
2021-06-04 Tom Tromey <tromey@adacore.com>
* dwarf2/read.h (dwarf2_fetch_die_type_sect_off): Add 'var_name'
diff --git a/gdb/NEWS b/gdb/NEWS
index ab678acec8b..56743fc9aea 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,9 @@
*** Changes since GDB 10
+* The 'set disassembler-options' command now supports specifying options
+ for the ARC target.
+
* GDB now supports general memory tagging functionality if the underlying
architecture supports the proper primitives and hooks. Currently this is
enabled only for AArch64 MTE.
diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
index ece802545c0..3afbf4264fe 100644
--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -2434,11 +2434,13 @@ arc_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
arc_disassembler_options = NULL;
break;
}
- set_gdbarch_disassembler_options (gdbarch,
- &arc_disassembler_options);
}
}
+ set_gdbarch_disassembler_options (gdbarch, &arc_disassembler_options);
+ set_gdbarch_valid_disassembler_options (gdbarch,
+ disassembler_options_arc ());
+
tdesc_use_registers (gdbarch, tdesc, std::move (tdesc_data));
return gdbarch;
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 82bc4f61eba..61d40b92e63 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-05 Shahab Vahedi <shahab@synopsys.com>
+
+ * gdb.texinfo (Source and Machine Code): Document 'set
+ disassembler-options' support for the ARC target.
+
2021-06-04 Hannes Domani <ssbssa@yahoo.de>
* python.texi (TUI Windows In Python): Document Window.click.
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 90d827a50e7..d09b86cda95 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -9879,8 +9879,8 @@ The default value is the empty string.
If it is necessary to specify more than one disassembler option, then
multiple options can be placed together into a comma separated list.
-Currently this command is only supported on targets ARM, MIPS, PowerPC
-and S/390.
+Currently this command is only supported on targets ARC, ARM, MIPS,
+PowerPC and S/390.
@kindex show disassembler-options
@item show disassembler-options
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4c07d3ae0ba..d78bf06d62c 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-05 Shahab Vahedi <shahab@synopsys.com>
+
+ * gdb.arch/arc-disassembler-options.exp: New test.
+ * gdb.arch/arc-disassembler-options.s: New test source.
+
2021-06-04 Tom Tromey <tromey@adacore.com>
* gdb.ada/array_of_symbolic_length.exp: New file.
diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.exp b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
new file mode 100644
index 00000000000..6bfe06b3d9d
--- /dev/null
+++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.exp
@@ -0,0 +1,45 @@
+# Copyright 2021 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test ARC disassembler options.
+
+if { ![istarget "arc-*-*"] } then {
+ verbose "Skipping ARC disassembler option test."
+ return
+}
+
+standard_testfile .s
+set objfile [standard_output_file ${testfile}.o]
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {}] \
+ != "" } {
+ return
+}
+
+clean_restart ${objfile}
+
+proc arc_disassemble_test { func insn mesg } {
+ gdb_test "disassemble $func" \
+ "Dump of assembler code for function $func:\r\n\
+ \[^:\]+:\t$insn\r\nEnd of assembler dump\." \
+ $mesg
+}
+
+# Verify defaults.
+arc_disassemble_test foo "lr\tr0,\\\[tlbpd0\\\]" "disassemble default"
+
+# Verify option overrides.
+gdb_test "set disassembler-options cpu=arcem"
+arc_disassemble_test foo "lr\tr0,\\\[1120\\\]" "disassemble cpu=arcem"
diff --git a/gdb/testsuite/gdb.arch/arc-disassembler-options.s b/gdb/testsuite/gdb.arch/arc-disassembler-options.s
new file mode 100644
index 00000000000..9f64ce43a43
--- /dev/null
+++ b/gdb/testsuite/gdb.arch/arc-disassembler-options.s
@@ -0,0 +1,21 @@
+# This test is part of GDB, the GNU debugger.
+#
+# Copyright 2021 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+.globl foo
+foo:
+ lr r0, [tlbpd0]
+.end foo
--
2.31.1
prev parent reply other threads:[~2021-06-05 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 17:42 [PATCH] " Shahab Vahedi
2021-06-03 18:55 ` Eli Zaretskii
2021-06-04 7:38 ` [PATCH v2] " Shahab Vahedi
2021-06-04 13:49 ` Tom Tromey
2021-06-05 9:50 ` Shahab Vahedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605095002.11338-1-shahab.vahedi@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=eliz@gnu.org \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).