From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use ACX_NONCANONICAL_TARGET in gdb/configure
Date: Sat, 5 Jun 2021 13:06:08 +0100 [thread overview]
Message-ID: <20210605120608.GS2672@embecosm.com> (raw)
In-Reply-To: <20210604202515.3429329-1-tromey@adacore.com>
* Tom Tromey <tromey@adacore.com> [2021-06-04 14:25:15 -0600]:
> Shahab Vahedipointed out that the patch to remove
> gdb/testsuite/configure regressed the site.exp creation a bit -- it
> left an unresolved configure substitution. Andrew Burgess pointed out
> that the patch removed the call to ACX_NONCANONICAL_TARGET, which
> caused this problem.
LGTM :)
Thanks,
Andrew
>
> This patch adds ACX_NONCANONICAL_TARGET to gdb's configure, and fixes
> the bug.
>
> gdb/ChangeLog
> 2021-06-04 Tom Tromey <tromey@adacore.com>
>
> * configure: Rebuild.
> * configure.ac: Add ACX_NONCANONICAL_TARGET.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/configure | 19 +++++++++++++++++++
> gdb/configure.ac | 2 ++
> 3 files changed, 26 insertions(+)
>
> diff --git a/gdb/configure b/gdb/configure
> index fb43377015c..3d3977b26a8 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -800,6 +800,7 @@ DEPDIR
> am__leading_dot
> CXX_DIALECT
> HAVE_CXX11
> +target_noncanonical
> INSTALL_STRIP_PROGRAM
> STRIP
> install_sh
> @@ -5186,6 +5187,24 @@ ac_configure="$SHELL $ac_aux_dir/configure" # Please don't use this var.
> # Set target, target_cpu, target_vendor, and target_os.
>
>
> + case ${build_alias} in
> + "") build_noncanonical=${build} ;;
> + *) build_noncanonical=${build_alias} ;;
> +esac
> +
> + case ${host_alias} in
> + "") host_noncanonical=${build_noncanonical} ;;
> + *) host_noncanonical=${host_alias} ;;
> +esac
> +
> + case ${target_alias} in
> + "") target_noncanonical=${host_noncanonical} ;;
> + *) target_noncanonical=${target_alias} ;;
> +esac
> +
> +
> +
> +
> test "$program_prefix" != NONE &&
> program_transform_name="s&^&$program_prefix&;$program_transform_name"
> # Use a double $ so make ignores it.
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index e6e1c6b7b90..df340ffa826 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -43,6 +43,8 @@ AC_CANONICAL_HOST
> # Set target, target_cpu, target_vendor, and target_os.
> AC_CANONICAL_TARGET
>
> +ACX_NONCANONICAL_TARGET
> +
> AC_ARG_PROGRAM
>
> # We require a C++11 compiler. Check if one is available, and if
> --
> 2.26.3
>
prev parent reply other threads:[~2021-06-05 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 20:25 Tom Tromey
2021-06-05 9:31 ` Shahab Vahedi
2021-06-05 14:15 ` Tom Tromey
2021-06-05 12:06 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605120608.GS2672@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).