From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id C266D385043F for ; Sat, 5 Jun 2021 12:06:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C266D385043F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x431.google.com with SMTP id a20so11960005wrc.0 for ; Sat, 05 Jun 2021 05:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t+nlBLF8o5mOzIZcWcRQxjgJVZ1IquU9f16Xd8hC4yI=; b=c0zXDTAntnF61aouOmacPoSTQw3kgUnbyoM2t5oiJ9vxEXgi5vAQwzGxYOlCimSEGI 4UJ908IoZ3OlF4GCPl+UeafXrwMRamotwXFpPwqwLv/YGuJJF+I0VLPHHcidL0jH8q68 CCCNeTKa1HL25jS0swtSFn8wlkSLvMUFdaQn6aXl76njZnMDM/jy7FZchAtTlWRNh4yu frGVZ+FWOW7cBAvucK48uyZii5P9bMF0tLW0r0JOzzEIcxQfq6Dr2nquERcp/6xH6Zba CxgkzERbjf3w6hh6NQXOUasCEXWmoWIiT1RZSLHigzqDXaAqf3X1/80Bos7XfVAANKWe Ml3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t+nlBLF8o5mOzIZcWcRQxjgJVZ1IquU9f16Xd8hC4yI=; b=a7IS6mhtphqyP0bRb3yPcr4rjiAplgtFbHljbbFlpxZ7mfY5mgyPViFJMCcB7nVZio DYURi09pwHoZw6Fka9zojiDwK5oypKrVxcD9/pF76/7jAyq0iy+9d07FOEeEKTw5r9PL sOI5AuaA3wEgN8bvg6Qs2AkJeoyZZq7RMlQBIil73q62FGDlnc62boq2qFjm9PovdsX2 DBcWp+/XYjfPHZbJ1jUom7erYstasVmERfq97Df5hY8W/E4RoX9Z3TDbyu8Hwa6QWN/M gAAD4fNGad/y7X2sHm7sP0ugmjhiUpmP9avIuHVOV5dmgg+HD7+yuBpw8QqgcsRDNKiu GqoA== X-Gm-Message-State: AOAM533MgexO8eyLIGO2xPBlzAWpddqOz2S5SecxFqbsJuNl3kIHLtY7 d54Mz+8I1k5otq/T2WV30uT8hIlz7JNDtg== X-Google-Smtp-Source: ABdhPJwoRFgzgf23jEdHxuyRPiu2MWKjNeJqGLsMR0i2cmPgMvST5iMDuxyno6BcrueL8e6JzAyKMA== X-Received: by 2002:a5d:5107:: with SMTP id s7mr2060772wrt.12.1622894769913; Sat, 05 Jun 2021 05:06:09 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id l10sm7324361wrs.11.2021.06.05.05.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 05:06:09 -0700 (PDT) Date: Sat, 5 Jun 2021 13:06:08 +0100 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use ACX_NONCANONICAL_TARGET in gdb/configure Message-ID: <20210605120608.GS2672@embecosm.com> References: <20210604202515.3429329-1-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604202515.3429329-1-tromey@adacore.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:05:55 up 17 days, 1:50, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2021 12:06:21 -0000 * Tom Tromey [2021-06-04 14:25:15 -0600]: > Shahab Vahedipointed out that the patch to remove > gdb/testsuite/configure regressed the site.exp creation a bit -- it > left an unresolved configure substitution. Andrew Burgess pointed out > that the patch removed the call to ACX_NONCANONICAL_TARGET, which > caused this problem. LGTM :) Thanks, Andrew > > This patch adds ACX_NONCANONICAL_TARGET to gdb's configure, and fixes > the bug. > > gdb/ChangeLog > 2021-06-04 Tom Tromey > > * configure: Rebuild. > * configure.ac: Add ACX_NONCANONICAL_TARGET. > --- > gdb/ChangeLog | 5 +++++ > gdb/configure | 19 +++++++++++++++++++ > gdb/configure.ac | 2 ++ > 3 files changed, 26 insertions(+) > > diff --git a/gdb/configure b/gdb/configure > index fb43377015c..3d3977b26a8 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -800,6 +800,7 @@ DEPDIR > am__leading_dot > CXX_DIALECT > HAVE_CXX11 > +target_noncanonical > INSTALL_STRIP_PROGRAM > STRIP > install_sh > @@ -5186,6 +5187,24 @@ ac_configure="$SHELL $ac_aux_dir/configure" # Please don't use this var. > # Set target, target_cpu, target_vendor, and target_os. > > > + case ${build_alias} in > + "") build_noncanonical=${build} ;; > + *) build_noncanonical=${build_alias} ;; > +esac > + > + case ${host_alias} in > + "") host_noncanonical=${build_noncanonical} ;; > + *) host_noncanonical=${host_alias} ;; > +esac > + > + case ${target_alias} in > + "") target_noncanonical=${host_noncanonical} ;; > + *) target_noncanonical=${target_alias} ;; > +esac > + > + > + > + > test "$program_prefix" != NONE && > program_transform_name="s&^&$program_prefix&;$program_transform_name" > # Use a double $ so make ignores it. > diff --git a/gdb/configure.ac b/gdb/configure.ac > index e6e1c6b7b90..df340ffa826 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -43,6 +43,8 @@ AC_CANONICAL_HOST > # Set target, target_cpu, target_vendor, and target_os. > AC_CANONICAL_TARGET > > +ACX_NONCANONICAL_TARGET > + > AC_ARG_PROGRAM > > # We require a C++11 compiler. Check if one is available, and if > -- > 2.26.3 >