Re: [PATCH] gdb: set only inferior_ptid in sparc_{fetch, store}_inferior_registers

[Joel Brobecker <brobecker@adacore.com>]

Hi Simon,

> gdb/ChangeLog:
> 
> 	PR gdb/27899
> 	* sparc-nat.c (sparc_fetch_inferior_registers): Set
> 	inferior_ptid instead of using switch_to_thread.
> 	(sparc_store_inferior_registers): Likewise.

Thanks for the patch. This looks good to me. Were you able to run
the testsuite on the patch? If not, I could probably run it against
AdaCore's testsuite on a LEON3 baremetal target -- not as good as
the full official testsuite on a SPARC/Linux machine, but better
than nothing...

Thanks!

> 
> Change-Id: I0b6ddb3af9b11f67b10ee46a734fb82ecc6462d5
> ---
>  gdb/sparc-nat.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c
> index fa3b32cee184..7f09a60420db 100644
> --- a/gdb/sparc-nat.c
> +++ b/gdb/sparc-nat.c
> @@ -170,9 +170,8 @@ sparc_fetch_inferior_registers (process_stratum_target *proc_target,
>  
>        /* Deep down, sparc_supply_rwindow reads memory, so needs the global
>  	 thread context to be set.  */
> -      thread_info *thread = find_thread_ptid (proc_target, ptid);
> -      scoped_restore_current_thread restore_thread;
> -      switch_to_thread (thread);
> +      scoped_restore restore_inferior_ptid
> +	= make_scoped_restore (&inferior_ptid, ptid);
>  
>        sparc_supply_gregset (sparc_gregmap, regcache, -1, &regs);
>        if (regnum != -1)
> @@ -219,9 +218,8 @@ sparc_store_inferior_registers (process_stratum_target *proc_target,
>  
>  	  /* Deep down, sparc_collect_rwindow writes memory, so needs the global
>  	     thread context to be set.  */
> -	  thread_info *thread = find_thread_ptid (proc_target, ptid);
> -	  scoped_restore_current_thread restore_thread;
> -	  switch_to_thread (thread);
> +	  scoped_restore restore_inferior_ptid
> +	    = make_scoped_restore (&inferior_ptid, ptid);
>  
>  	  sparc_collect_rwindow (regcache, sp, regnum);
>  	}
> -- 
> 2.31.1
> 

-- 
Joel