From: Ulrich Weigand <uweigand@de.ibm.com>
To: Carl Love <cel@us.ibm.com>
Cc: gdb-patches@sourceware.org,
Pedro Franco de Carvalho <pedromfc@linux.ibm.com>,
Rogerio Alves <rogealve@br.ibm.com>
Subject: Re: [PATCH] Add Power 10 PLT instruction patterns
Date: Mon, 7 Jun 2021 14:54:00 +0200 [thread overview]
Message-ID: <20210607125400.GA20603@oc3748833570.ibm.com> (raw)
In-Reply-To: <1984418036f52962c1436bafdcc720c8fa2ce699.camel@us.ibm.com>
On Fri, Jun 04, 2021 at 08:28:15AM -0700, Carl Love wrote:
> gdb/ChangeLog:
>
> 2021-06-06 Carl Love <cel@us.ibm.com>
>
> * ppc-tdep.h: New extern ppc_insn_prefix_dform.
> * ppc64-tdep.c: New defines prefix, insn_md, insn_x, insn_xo.
> New functions ppc64_plt_pcrel_entry_point, ppc64_pcrel_linkage1_target,
> ppc64_pcrel_linkage2_target.
> New ppc instruction patterns ppc64_standard_linkage9,
> ppc64_standard_linkage10, ppc64_standard_linkage11,
> ppc64_standard_linkage12.
> Add ppc64_standard_linkage9, ppc64_standard_linkage10,
> ppc64_standard_linkage11, ppc64_standard_linkage12 to define MAX
> expression.
> (ppc64_skip_trampoline_code_1): Add if statement checks for
> ppc64_standard_linkage9, ppc64_standard_linkage10,
> ppc64_standard_linkage11, ppc64_standard_linkage12.
> * New function ppc_insn_prefix_dform.
The patch is OK. Please format the ChangeLog according to the
usual rules, in particular each new or changed "entity" should go
in parentheses, like e.g. so:
* ppc-tdep.h (ppc_insn_prefix_dform): Declare.
* ppc64-tdep.c (prefix, insn_md, insn_x, insn_xo): New macros.
(ppc64_plt_pcrel_entry_point, ppc64_pcrel_linkage1_target,
ppc64_pcrel_linkage2_target): New functions.
(ppc64_standard_linkage9, ppc64_standard_linkage10,
ppc64_standard_linkage11, ppc64_standard_linkage12): New variables.
(ppc64_skip_trampoline_code_1): Handle
ppc64_standard_linkage9, ppc64_standard_linkage10,
ppc64_standard_linkage11, and ppc64_standard_linkage12.
* rs6000-tdep.c (ppc_insn_prefix_dform): New function.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2021-06-07 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 15:28 Carl Love
2021-06-07 12:54 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607125400.GA20603@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
--cc=rogealve@br.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).