From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0FF6E3853826 for ; Mon, 7 Jun 2021 12:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FF6E3853826 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 157Cn0ID043756 for ; Mon, 7 Jun 2021 08:54:08 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 391kswr4qw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 Jun 2021 08:54:08 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 157Cmje8022066 for ; Mon, 7 Jun 2021 12:54:06 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 3900w8ggeq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 Jun 2021 12:54:05 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 157Cs1Ik26935782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Jun 2021 12:54:01 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 93E4AAE059; Mon, 7 Jun 2021 12:54:01 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 80DDAAE051; Mon, 7 Jun 2021 12:54:01 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.145.161.253]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 7 Jun 2021 12:54:01 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id E879AD80347; Mon, 7 Jun 2021 14:54:00 +0200 (CEST) Date: Mon, 7 Jun 2021 14:54:00 +0200 From: Ulrich Weigand To: Carl Love Cc: gdb-patches@sourceware.org, Pedro Franco de Carvalho , Rogerio Alves Subject: Re: [PATCH] Add Power 10 PLT instruction patterns Message-ID: <20210607125400.GA20603@oc3748833570.ibm.com> References: <1984418036f52962c1436bafdcc720c8fa2ce699.camel@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1984418036f52962c1436bafdcc720c8fa2ce699.camel@us.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: vzImTU4aBoSWr1aY7qJ7PPtomBEX4N9z X-Proofpoint-GUID: vzImTU4aBoSWr1aY7qJ7PPtomBEX4N9z X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-07_10:2021-06-04, 2021-06-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 mlxlogscore=402 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106070095 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 12:54:18 -0000 On Fri, Jun 04, 2021 at 08:28:15AM -0700, Carl Love wrote: > gdb/ChangeLog: > > 2021-06-06 Carl Love > > * ppc-tdep.h: New extern ppc_insn_prefix_dform. > * ppc64-tdep.c: New defines prefix, insn_md, insn_x, insn_xo. > New functions ppc64_plt_pcrel_entry_point, ppc64_pcrel_linkage1_target, > ppc64_pcrel_linkage2_target. > New ppc instruction patterns ppc64_standard_linkage9, > ppc64_standard_linkage10, ppc64_standard_linkage11, > ppc64_standard_linkage12. > Add ppc64_standard_linkage9, ppc64_standard_linkage10, > ppc64_standard_linkage11, ppc64_standard_linkage12 to define MAX > expression. > (ppc64_skip_trampoline_code_1): Add if statement checks for > ppc64_standard_linkage9, ppc64_standard_linkage10, > ppc64_standard_linkage11, ppc64_standard_linkage12. > * New function ppc_insn_prefix_dform. The patch is OK. Please format the ChangeLog according to the usual rules, in particular each new or changed "entity" should go in parentheses, like e.g. so: * ppc-tdep.h (ppc_insn_prefix_dform): Declare. * ppc64-tdep.c (prefix, insn_md, insn_x, insn_xo): New macros. (ppc64_plt_pcrel_entry_point, ppc64_pcrel_linkage1_target, ppc64_pcrel_linkage2_target): New functions. (ppc64_standard_linkage9, ppc64_standard_linkage10, ppc64_standard_linkage11, ppc64_standard_linkage12): New variables. (ppc64_skip_trampoline_code_1): Handle ppc64_standard_linkage9, ppc64_standard_linkage10, ppc64_standard_linkage11, and ppc64_standard_linkage12. * rs6000-tdep.c (ppc_insn_prefix_dform): New function. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com