From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic307-54.consmr.mail.ir2.yahoo.com (sonic307-54.consmr.mail.ir2.yahoo.com [87.248.110.31]) by sourceware.org (Postfix) with ESMTPS id BADDF3886C7A for ; Mon, 7 Jun 2021 16:30:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BADDF3886C7A X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1623083426; bh=Zj1CfQN3KoYf/fgcsIjHoCJ3F7+dgIM1lafq7ik5rO7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=R27mbYZMNLa2ULDiWn9agyY1httM9r4vFN3+h5kxAlpW3026rYWcif+IWyby5FPnrIvDaqdIGk4vvBoPnITihIwlCSxjM1uoJKuekND5t746yHujpymbRPh9otkD1v13ekgpiJbCBIlbGykW7jcowTiEjr5hPBBrTIzjBBtPbnpjy6IDws4dij+BpuD1lWYLJ3/2/X60pWBLsh84BtTMsGid5fK5RNtNavUU30SSGp8OTroXulqLSldkL7EYRcc1NbkgfZQYNILESyCJU/+sbQUVw50YGc/YD6hJa0fTnMB14z7wO08nzdVJB3ndZc0p0u2Av1WvSdAyBIEjt/xy8g== X-YMail-OSG: 18KsWtYVM1nq9YkWriowR4IkofCgeFS0K.GNtRfcZ7tEomkNKvPRMZAYh4q1zqI kFjDxDnsSdTM.E2ZIK3csQ9AnOYq0qTXJgham5ggthvcxbmW.AyUTAtA0B9lASgtSePpruz6hoOf YnLaden4rNT_IckkeAQ1zGxDwDuzilMvzSlESrXBLVIXekJhtjxIe.y8SDmSFn1ntkKql5sRdSYP sz09x6IlskWZaM2gk_mhkH37JvGN2zXg1KvEdUrYncyaPaTrtIQyTXSnMuxwdExBAjo8Mz7XrGoW 2xkSghytW9LBwyNKjGHLxok.pmYrQzlsQwKw5S110Sb8IVOob_dBqzm7eDcpLUUUBH9Hzynqry3g vBeOvOWoOIm0ClOcVDe_2DdFYpMiLpKabPP1w.ip8qRWUQYERkcNeimID.xpzQn3HDQNxnvAaSbZ IwICAj4pguDDq98hZJLTxMnskRAZ9elNAG5Mn7VH4OygiBsPAhgqjXQ6DwfuM0VuUkCFR7Iy82UA _cY6GzLVuWGRhn3wHWDTXABef4AI9jxawQ0D7fwS12SlW8HPubD0pZyV8EszqSyX_duvijjDRLtP 166QNkMdPHNWcewQQMs7nXWXWBuTp5KKXmlYL3bZBifJc8gMUTvue7hqNV7JoLPUKT6BBhSqklOv rmFx5AnAd7Ie59Qcx81esbrO4kZX778cKQd6FL5VWZzlVb.g8VG1UAcO19qnVg1icao7gHc__RSe tS9rKYA9hzuwH5ksnukGJtB4IDif54nJiqtNg4E8opXpBYj8aC0tXq35T2hDLxAN61ZecdXjhqYR v0cRl6QydA76UT6tABZJlKwd7Rc9Y7JloQWSikf0RRvpj87pIgyp1qvK_k.B3TfNDZNV3Iz7yMAE i_HqqTEWXHcQmL2ekLiLF3V5e6VQmUibz98aoUiweGvJNCM84APhErAeXt5KnpWG7luwbr4AnjGa yLbLNp4GpY1H1syeENfzZ1EYerQCJGKJWbDbErTeUX0dnGjG2P2Q6ecgS8UMG_oXJOMorm88Ywoz g51hQyA5viUwx9hgcsiWBSbTXYrXXiIWnJnlV2Qiu.e8Yzs6f0GrtKeHLGCOWEI1KsOXjM0kNitz tRDEXhEH3FREwQI7JajcNaBmQP4Ps1hiSFzUa0OsjdG3u1KCFx3gIe8xWunQX7BgzaoSytzvp_Ds QlPJCHPjhvQB5iNmjCdGcwASFwms.QjWGr_NXnUfE3trIXkspAuwh8T.kOzWWyr7O2bBqDcqIf33 KlY_gocTHcKEPGezFeNR1ExebsqM3EYsWAGofKhZy3lP0Wqnt0TIREyHY6cBxSdcaVeEavl5JxNl P7HP0zXqkEDKHJJOH.ZyFAGjyU4zUyU5qYu42obXNfHOkuuYnYLzmiNq.IG0ys.1uaMz2yf66N5G Jmi2a93tvPc9Zk8Xur2qiaf6mqePW4cCafGXUGH89VwGfBF7w3kMvv6fn93FBexZ0_h_ySHXOZza yJbvtKrSDcxRspYpfwT5uAXhZ6ZhVpQFrVlt6PwLmcoPqxn7Hr_KeObUbgHadgRWBtHpsaoRB.lH MgIUKEbjd0jle_6uRh93Jx7bihU.NdkGyMA5kqO_kkGO6rkmwdluB36AbRLlOgbUfSSsnj2ehmfD _5wO5whF0TRhAJEcDob6isEInc_T0a7XoOVx_qtWUitSA_IaKYS_YdsCfb7Zq9WjN8zHwTWgglPV UvXhrQf9HQGc2Q0vqXeUUDUBp5ByxbrBUSE5.Ky85s1h3zFi7bUMRSqeNmmNrc1z.J4ccUue6ql7 DOUa.6UJsMt1Ix_YN7fJIlz4CEZ.PDbfEhWXPSy4492GEqi7mlQam.NLGUZ6GoEd6OXNRM7BEBtM nF43mrJBF.FTnTXZ3RwZZD3Q8clcPVljap0LagYY1wVGqI8ODHZ28LcO8dIQNHLEm1xNgOUMTVdw SPKkJX3vw5IQUhVlOuT2SHEw6smcN2Ur6jV6Za7j8qECOVVnDA4C0ahc1S0cX5sWWnwmG7ScznwE xwdHfsz5Rr72meF6JuzEBZK9U.RoTEiliAOJdBPfy0otVj2LpA_3uPEJV7wjuQSunUB3QQ4dZ29a StKP.SpOYsFdC382RNk0VfG381JOx05OTDK8GBJTL2AoQkPSd7G0NAtK5c8mdEF8RRXtXdVo0dRd QVVDEaDcgJFr16VoaDf2FTjnm07X5mvyIJp22fo5IsZSbxC_BUS02yolg6oUCgRCjMOdja0QmKm8 WntiLR.Oz3Q36czYP0SSYtkXCuddczvTAA45ISCf0kM5w1wUNMtajRnorlsLmTXB26Gdgk.4FJIo ulcPAZiSDsKPH8uBjfyd69ytBy6_HPGxmkdWRWfiUEV0zpFXcLrXm1D1muG2zC7EK8PyczKCSeKQ DbeE2jR2q9q2rHySibjzRZ2cHAVCPE4rm0xI4IAyULrRf6Ltk38cOnoDKPBnYxJFklVSXRA6ikDA PlvU- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Mon, 7 Jun 2021 16:30:26 +0000 Received: by kubenode550.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 86869961c06f18b14dd725624d84c1da; Mon, 07 Jun 2021 16:30:23 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Subject: [PATCH 1/3] Refactor keypad calls to tui_set_win_focus_to Date: Mon, 7 Jun 2021 18:30:01 +0200 Message-Id: <20210607163003.621-1-ssbssa@yahoo.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Antivirus: Avast (VPS 210607-4, 06/07/2021), Outbound message X-Antivirus-Status: Clean References: <20210607163003.621-1-ssbssa.ref@yahoo.de> X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 16:30:29 -0000 Previously it always was called after tui_set_win_focus_to, except it was missing in tui_apply_current_layout. gdb/ChangeLog: 2021-06-07 Hannes Domani * tui/tui-data.c (tui_set_win_focus_to): Add keypad call. * tui/tui-win.c (tui_set_focus_command): Remove keypad call. * tui/tui.c (tui_rl_other_window): Likewise. (tui_enable): Likewise. --- gdb/tui/tui-data.c | 5 +++++ gdb/tui/tui-win.c | 1 - gdb/tui/tui.c | 2 -- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index 691459abe2a..89afdb429ba 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -22,6 +22,7 @@ #include "defs.h" #include "symtab.h" #include "tui/tui.h" +#include "tui/tui-command.h" #include "tui/tui-data.h" #include "tui/tui-win.h" #include "tui/tui-wingeneral.h" @@ -69,6 +70,10 @@ tui_set_win_focus_to (struct tui_win_info *win_info) tui_unhighlight_win (win_with_focus); win_with_focus = win_info; tui_highlight_win (win_info); + + /* Enable the keypad if any window except the command window has + the focus. */ + keypad (TUI_CMD_WIN->handle.get (), win_info != TUI_CMD_WIN); } } diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index 4e75a66a00e..094b503eae8 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -703,7 +703,6 @@ tui_set_focus_command (const char *arg, int from_tty) error (_("Window \"%s\" is not visible"), arg); tui_set_win_focus_to (win_info); - keypad (TUI_CMD_WIN->handle.get (), win_info != TUI_CMD_WIN); printf_filtered (_("Focus set to %s window.\n"), tui_win_with_focus ()->name ()); } diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index 529fc62c9ac..394c357cebb 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -181,7 +181,6 @@ tui_rl_other_window (int count, int key) if (win_info) { tui_set_win_focus_to (win_info); - keypad (TUI_CMD_WIN->handle.get (), win_info != TUI_CMD_WIN); } return 0; } @@ -439,7 +438,6 @@ tui_enable (void) tui_show_frame_info (0); tui_set_initial_layout (); tui_set_win_focus_to (TUI_SRC_WIN); - keypad (TUI_CMD_WIN->handle.get (), TRUE); wrefresh (TUI_CMD_WIN->handle.get ()); tui_finish_init = false; } -- 2.31.1