* [pushed] gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main
@ 2021-06-07 16:53 Simon Marchi
0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2021-06-07 16:53 UTC (permalink / raw)
To: gdb-patches
While doing some changes, I managed to break this test in a way that
running to main didn't work. However, it didn't produce any FAIL. I
noticed because I diff'ed the results and saw some PASSes unexpectedly
disappear, but that's a bit fragile. Add a fail in case this test fails
to run to main. Ideally, I think that runto_main should by default
produce a FAIL when it fails (the opposite of the existing logic), but
that's a project of its own, so just fix this test for the moment.
gdb/testsuite/ChangeLog:
* gdb.base/continue-all-already-running.exp: Call fail if can't
run to main.
Change-Id: I84b816a126c92ac579ed5ebbe39b017bd5cb7096
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.base/continue-all-already-running.exp | 1 +
2 files changed, 6 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fd78401774b0..45040960d0f0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-07 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * gdb.base/continue-all-already-running.exp: Call fail if can't
+ run to main.
+
2021-06-07 Andrew Burgess <andrew.burgess@embecosm.com>
PR gdb/27847
diff --git a/gdb/testsuite/gdb.base/continue-all-already-running.exp b/gdb/testsuite/gdb.base/continue-all-already-running.exp
index 23cd9920bc73..de84897c7667 100644
--- a/gdb/testsuite/gdb.base/continue-all-already-running.exp
+++ b/gdb/testsuite/gdb.base/continue-all-already-running.exp
@@ -26,6 +26,7 @@ save_vars { GDBFLAGS } {
}
if ![runto_main] {
+ fail "can't run to main"
return
}
--
2.31.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-07 16:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 16:53 [pushed] gdb/testsuite: gdb.base/continue-all-already-running.exp: add fail if can't run to main Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).