From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 4F6B23854812 for ; Mon, 7 Jun 2021 23:26:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F6B23854812 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f50.google.com with SMTP id f16-20020a05600c1550b02901b00c1be4abso722654wmg.2 for ; Mon, 07 Jun 2021 16:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=B90+cJ3L798Jw9e1AKLytdp91UZA/QVt12hiZArjJgE=; b=q4DuPINF47eC+9uMua27P++Wz249Ee48BNEeZT1S1eBwRJoCEAXHJUWl4PaIhBIbiR 0JEgoapq576ZYZe0w03NiYRpNS4WANxqgg7f6+LhBZX3EmZndv+JLPTsowkZzCccsibT N4h5wDGlEUPQ8Z1AbMoBEGj1iEzfxtifFvq7ebK33Z4P6Iyhf+ML8u5Hxgk/H/f/1lLb nQL8qkM65wqoqtHLvZsk/FGt+OCiH/eZSPhYCtUU7VPJ9m/ydxG5HJBFEd5rAcNRMVXY EwUhblCwHDppvDWN1JMmOfggCXDuyQXMEXTY8jewakDcc1JysaCN6uIl0r9oQRNx5X7J cOrQ== X-Gm-Message-State: AOAM533VumHnD8l6NtFhq5lrRFxNEcJz2tJqMbE9qhmbOmZMQlON1BSS UW04fIIHKrbFFXRUh1jf9QbDy1L+ShHlIQ== X-Google-Smtp-Source: ABdhPJzDYpGZNftTqkfnfZjzvpfFgs0SP1rudnTIjh+5UOll4pleYn4xBR50Iq5Tnt7OwEyAPtdNpA== X-Received: by 2002:a05:600c:35c1:: with SMTP id r1mr8187215wmq.13.1623108417833; Mon, 07 Jun 2021 16:26:57 -0700 (PDT) Received: from localhost ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id r4sm17523104wre.84.2021.06.07.16.26.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 16:26:56 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [ob/pushed] Fix a couple -Wdeprecated-copy issues Date: Tue, 8 Jun 2021 00:26:55 +0100 Message-Id: <20210607232655.1419237-1-pedro@palves.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 23:27:09 -0000 Building GDB with current git (future 13) Clang runs into these two issues: #1: src/gdb/symtab.h:1139:3: error: definition of implicit copy assignment operator for 'symbol' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy] symbol (const symbol &) = default; ^ #2: src/gdb/dwarf2/read.c:834:23: error: definition of implicit copy constructor for 'partial_die_info' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy] partial_die_info& operator=(const partial_die_info& rhs) = delete; ^ Fix them by adding the explicit defaulted versions of copy ctor and copy-assign op appropriately. gdb/ChangeLog: yyyy-mm-dd Pedro Alves * dwarf2/read.c (struct partial_die_info): Add defaulted copy ctor. * symtab.h (struct symbol): Add defaulted copy assignment operator. --- gdb/ChangeLog | 7 +++++++ gdb/dwarf2/read.c | 1 + gdb/symtab.h | 1 + 3 files changed, 9 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3026d383dd0..53d77aab62a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2021-06-07 Pedro Alves + + * dwarf2/read.c (struct partial_die_info): Add defaulted copy + ctor. + * symtab.h (struct symbol): Add defaulted copy assignment + operator. + 2021-06-07 Pedro Alves * completer.c (RL_QF_SINGLE_QUOTE, RL_QF_DOUBLE_QUOTE) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index de79454a85f..96009f1418f 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -832,6 +832,7 @@ struct partial_die_info : public allocate_on_obstack /* Disable assign but still keep copy ctor, which is needed load_partial_dies. */ partial_die_info& operator=(const partial_die_info& rhs) = delete; + partial_die_info (const partial_die_info &) = default; /* Adjust the partial die before generating a symbol for it. This function may set the is_external flag or change the DIE's diff --git a/gdb/symtab.h b/gdb/symtab.h index efdbada9761..a5d0168faf0 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -1137,6 +1137,7 @@ struct symbol : public general_symbol_info, public allocate_on_obstack } symbol (const symbol &) = default; + symbol &operator= (const symbol &) = default; /* Data type of value */ base-commit: fa6ec8efa4b902f65a8057b5ee3ba0da456ec8c2 -- 2.26.2