* [committed][gdb/testsuite] Fix gdb.base/sect-cmd.exp
@ 2021-06-08 8:05 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-06-08 8:05 UTC (permalink / raw)
To: gdb-patches
Hi,
With a testsuite setup modified to make expect wait a little bit longer for
gdb output (see PR27957), I reliably run into:
...
(gdb) FAIL: gdb.base/sect-cmd.exp: set section .text to original \
address (timeout)
...
The problem is a too greedy regexp:
...
-re ".*$address1 \- $address2 is $section_name.*" {
...
which ends up consuming the gdb prompt with the terminating ".*".
Fix this by limiting the regexp to a single line.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix gdb.base/sect-cmd.exp
gdb/testsuite/ChangeLog:
2021-06-08 Tom de Vries <tdevries@suse.de>
* gdb.base/sect-cmd.exp: Fix saw_section_address_line regexp.
---
gdb/testsuite/gdb.base/sect-cmd.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/sect-cmd.exp b/gdb/testsuite/gdb.base/sect-cmd.exp
index 7aa24ca615f..cb1e4464a69 100644
--- a/gdb/testsuite/gdb.base/sect-cmd.exp
+++ b/gdb/testsuite/gdb.base/sect-cmd.exp
@@ -58,7 +58,7 @@ if { $address1 == "" || $address2 == "" || $section_name == "" } {
set saw_section_address_line false
gdb_test_multiple "section $section_name $address1" \
"set section $section_name to original address" {
- -re ".*$address1 \- $address2 is $section_name.*" {
+ -re ".*$address1 \- $address2 is $section_name in \[^\r\n\]*" {
set saw_section_address_line true
exp_continue
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-08 8:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 8:05 [committed][gdb/testsuite] Fix gdb.base/sect-cmd.exp Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).