From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CA62038654A3 for ; Tue, 8 Jun 2021 08:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA62038654A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CB510219C2 for ; Tue, 8 Jun 2021 08:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623139536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=02Vvg9utlnXUynGB7glPmohj3J9o9ZBipEwybgbe7D4=; b=mIEeUll7FvfqsC9/3X3VEj8Q8hGp0lo9zbI1GIZq7YXT1JJL2vfV/9CJj9DlKmhidYM9sU oRI/DWiV4TvAt4jAz+xRlQHxC8FdiE+MV1jS/vkHqA4Ffhxa+IXjmbhWjyz57zUA9BPmSu mW1oEM85HkC9/lrumyVFXPkRAMS9B6s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623139536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=02Vvg9utlnXUynGB7glPmohj3J9o9ZBipEwybgbe7D4=; b=393xsyFSlmV6qI8rXoVHM9UAB66p7qzpQ7CGfmazmaK0DNpbIzho7bv6I0MHheyCXLX/u+ 62lZ8XocDhpxLfAQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id AE386118DD for ; Tue, 8 Jun 2021 08:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623139536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=02Vvg9utlnXUynGB7glPmohj3J9o9ZBipEwybgbe7D4=; b=mIEeUll7FvfqsC9/3X3VEj8Q8hGp0lo9zbI1GIZq7YXT1JJL2vfV/9CJj9DlKmhidYM9sU oRI/DWiV4TvAt4jAz+xRlQHxC8FdiE+MV1jS/vkHqA4Ffhxa+IXjmbhWjyz57zUA9BPmSu mW1oEM85HkC9/lrumyVFXPkRAMS9B6s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623139536; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=02Vvg9utlnXUynGB7glPmohj3J9o9ZBipEwybgbe7D4=; b=393xsyFSlmV6qI8rXoVHM9UAB66p7qzpQ7CGfmazmaK0DNpbIzho7bv6I0MHheyCXLX/u+ 62lZ8XocDhpxLfAQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id OGknKdAkv2DiLgAALh3uQQ (envelope-from ) for ; Tue, 08 Jun 2021 08:05:36 +0000 Date: Tue, 8 Jun 2021 10:05:35 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.base/sect-cmd.exp Message-ID: <20210608080534.GA14596@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 08:05:39 -0000 Hi, With a testsuite setup modified to make expect wait a little bit longer for gdb output (see PR27957), I reliably run into: ... (gdb) FAIL: gdb.base/sect-cmd.exp: set section .text to original \ address (timeout) ... The problem is a too greedy regexp: ... -re ".*$address1 \- $address2 is $section_name.*" { ... which ends up consuming the gdb prompt with the terminating ".*". Fix this by limiting the regexp to a single line. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.base/sect-cmd.exp gdb/testsuite/ChangeLog: 2021-06-08 Tom de Vries * gdb.base/sect-cmd.exp: Fix saw_section_address_line regexp. --- gdb/testsuite/gdb.base/sect-cmd.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/sect-cmd.exp b/gdb/testsuite/gdb.base/sect-cmd.exp index 7aa24ca615f..cb1e4464a69 100644 --- a/gdb/testsuite/gdb.base/sect-cmd.exp +++ b/gdb/testsuite/gdb.base/sect-cmd.exp @@ -58,7 +58,7 @@ if { $address1 == "" || $address2 == "" || $section_name == "" } { set saw_section_address_line false gdb_test_multiple "section $section_name $address1" \ "set section $section_name to original address" { - -re ".*$address1 \- $address2 is $section_name.*" { + -re ".*$address1 \- $address2 is $section_name in \[^\r\n\]*" { set saw_section_address_line true exp_continue }