From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 93B01398A425 for ; Thu, 10 Jun 2021 17:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93B01398A425 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-6a5U1E3bOTmBxO8IqAZTfQ-1; Thu, 10 Jun 2021 13:27:41 -0400 X-MC-Unique: 6a5U1E3bOTmBxO8IqAZTfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E1ACA40C1 for ; Thu, 10 Jun 2021 17:27:40 +0000 (UTC) Received: from f33-1.lan (ovpn-113-207.phx2.redhat.com [10.3.113.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A0AA10016F8; Thu, 10 Jun 2021 17:27:40 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [PATCH 4/4] mi-sym-info.exp: Increase timeout for 114-symbol-info-functions Date: Thu, 10 Jun 2021 10:26:41 -0700 Message-Id: <20210610172641.1052704-5-kevinb@redhat.com> In-Reply-To: <20210610172641.1052704-1-kevinb@redhat.com> References: <20210610172641.1052704-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 17:27:46 -0000 Loading libc.so's symbols increased the amount of time needed for 114-symbol-info-function to fetch symbols, causing a timeout during my testing. I enclosed the entire block with a "with_timeout_factor 4", which fixes the problem for me. (Using 2 also fixed it for me, but it might not be enough when running this test on slower machines.) gdb/testsuite/ChangeLog: * gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase timeout. --- gdb/testsuite/gdb.mi/mi-sym-info.exp | 56 ++++++++++++++-------------- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp index 18f85182a7b..dcd6f7d9187 100644 --- a/gdb/testsuite/gdb.mi/mi-sym-info.exp +++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp @@ -123,33 +123,35 @@ gdb_test_multiple $cmd $testname -prompt "${mi_gdb_prompt}$" { # (from the symbol table). There's often so much output output from # this command that we overflow expect's buffers, avoid this by # fetching the output piece by piece. -set testname "List all functions" -set cmd "114-symbol-info-functions --include-nondebug" -set state 0 -gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { - -re "114\\^done,symbols=\{" { - if { $state == 0 } { set state 1 } - exp_continue - } - -re "debug=\\\[${symtab_re}" { - if { $state == 1 } { set state 2 } - exp_continue - } - -re ",${symtab_re}" { - exp_continue - } - -re "\\\],nondebug=\\\[" { - if { $state == 2 } { set state 3 } - exp_continue - } - -re "\{address=${qstr},name=${qstr}\}," { - exp_continue - } - -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { - if { $state == 3 } { - pass $gdb_test_name - } else { - fail $gdb_test_name +with_timeout_factor 4 { + set testname "List all functions" + set cmd "114-symbol-info-functions --include-nondebug" + set state 0 + gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { + -re "114\\^done,symbols=\{" { + if { $state == 0 } { set state 1 } + exp_continue + } + -re "debug=\\\[${symtab_re}" { + if { $state == 1 } { set state 2 } + exp_continue + } + -re ",${symtab_re}" { + exp_continue + } + -re "\\\],nondebug=\\\[" { + if { $state == 2 } { set state 3 } + exp_continue + } + -re "\{address=${qstr},name=${qstr}\}," { + exp_continue + } + -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { + if { $state == 3 } { + pass $gdb_test_name + } else { + fail $gdb_test_name + } } } } -- 2.31.1