From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tom@tromey.com>
Cc: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>,
Weimin Pan <weimin.pan@oracle.com>
Subject: Re: [PATCH V5] CTF: multi-CU and archive support
Date: Sat, 12 Jun 2021 00:14:12 +0100 [thread overview]
Message-ID: <20210611231412.4nlxzgoepaomw6bu@Plymouth> (raw)
In-Reply-To: <87y2bgfena.fsf@tromey.com>
On Fri, Jun 11, 2021 at 12:19:05PM -0600, Tom Tromey wrote:
> >>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Lancelot> Should be
>
> Lancelot> if (sym != nullptr)
>
> Agreed.
>
> >> pst = new ctf_psymtab (name, partial_symtabs, objfile->per_bfd, 0);
>
> Lancelot> I am a bit confused by this one. As far as I can see, there is no way
> Lancelot> it can ever be deleted. Again, I am not so familiar with the code yet
> Lancelot> so I might have missed something, but hopefully not.
>
> psymtabs register themselves with a storage object.
> This is unfortunate but it is how it has been done for a long time, and
> nobody has bothered to clean it up.
>
> Tom
Thanks for the info. This is something I missed initially. “naked
new”s without obvious deletes tend to raise some alarms when I read
code…
Lancelot.
next prev parent reply other threads:[~2021-06-11 23:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 0:20 Weimin Pan
2021-05-25 0:52 ` [PING][PATCH " Wei-min Pan
2021-06-02 0:05 ` [PING 2][PATCH " Wei-min Pan
2021-06-09 0:37 ` [PING 3][PATCH " Wei-min Pan
2021-06-10 0:40 ` [PATCH " Lancelot SIX
2021-06-10 21:15 ` Wei-min Pan
2021-06-11 23:07 ` Lancelot SIX
2021-06-11 18:19 ` Tom Tromey
2021-06-11 23:14 ` Lancelot SIX [this message]
2021-06-11 18:17 ` Tom Tromey
2021-06-11 20:26 ` Wei-min Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611231412.4nlxzgoepaomw6bu@Plymouth \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).