From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net
 [IPv6:2001:41d0:801:2000::2400])
 by sourceware.org (Postfix) with ESMTPS id DA526384404C
 for <gdb-patches@sourceware.org>; Fri, 11 Jun 2021 23:14:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA526384404C
Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:ccd2:26d1:a133:8d62])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 0009E818D5;
 Fri, 11 Jun 2021 23:14:15 +0000 (UTC)
Date: Sat, 12 Jun 2021 00:14:12 +0100
From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tom@tromey.com>
Cc: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>,
 Weimin Pan <weimin.pan@oracle.com>
Subject: Re: [PATCH V5] CTF: multi-CU and archive support
Message-ID: <20210611231412.4nlxzgoepaomw6bu@Plymouth>
References: <1621297225-2332-1-git-send-email-weimin.pan@oracle.com>
 <20210610003512.auljolwwl5tmcrvx@Plymouth>
 <87y2bgfena.fsf@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87y2bgfena.fsf@tromey.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Fri, 11 Jun 2021 23:14:16 +0000 (UTC)
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2021 23:14:18 -0000

On Fri, Jun 11, 2021 at 12:19:05PM -0600, Tom Tromey wrote:
> >>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Lancelot> Should be
> 
> Lancelot> if (sym != nullptr)
> 
> Agreed.
> 
> >> pst = new ctf_psymtab (name, partial_symtabs, objfile->per_bfd, 0);
> 
> Lancelot> I am a bit confused by this one.  As far as I can see, there is no way
> Lancelot> it can ever be deleted.  Again, I am not so familiar with the code yet
> Lancelot> so I might have missed something, but hopefully not.
> 
> psymtabs register themselves with a storage object.
> This is unfortunate but it is how it has been done for a long time, and
> nobody has bothered to clean it up.
> 
> Tom

Thanks for the info.  This is something I missed initially.  “naked
new”s without obvious deletes tend to raise some alarms when I read
code…

Lancelot.