From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id CDAFF3857818 for ; Wed, 23 Jun 2021 12:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDAFF3857818 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x330.google.com with SMTP id p10-20020a05600c430ab02901df57d735f7so3857357wme.3 for ; Wed, 23 Jun 2021 05:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=65YJHqPjr4/bvsjYlsSoM7uU3k3fdkRlIyaRJQtFTYE=; b=dQWPpV0mVzGasMePHAk4YVM4McR2frIGnk7Gv24oep/o/+kEHdEahjMQIznK2eHyOa UtABy+GnZIHeMH7u8qb0EnLR0dauVypsgYpT+6tbF4GSq45jz8xsgeTyaZcd555E8LbX 7fbJb4VIHp3gpDfOyyW3rM6QKxxa/sj7j9UdYhkKKLrs0hJghXwc07Lu0uFRegvOCzSz nLaQ2wGU/KHxfmb/oebTSv29z1Vi4utgSwWFbIRieBkUzcW1LTm9BZI1QGWUeMQm1s9J WNWEboAAGnE2NOUasmEXzO4xWaj3Gj0NzhMvvzbpaqgxLrhfwxCkLOZdVx9xeWphdrMz GOvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=65YJHqPjr4/bvsjYlsSoM7uU3k3fdkRlIyaRJQtFTYE=; b=OcURwdao7QFMrJZieF418Q4QeQTWQLV2FrJU38jQh6X7aVmU8lErm0m0Ke2absRDhq utzubrBYiYvnBkv4N7VkiK/XFVsEGLAf6iEjC9Q7hlytlb7PFKslJcBkP/Z2d62Mm8Em pazxjYs6lJCOyxqpKQbbE56Kfb7GaARwRXvIJmVobkA0LRMe+PzuslmdHdVSNSThaM1Y uGcPYPOhUCnF1/f6GoQ6RJtLZtCt4nR0sIeSpjQaGLfn3+o5BSy2dfGFTbZXln60P3Jx fx/Al/P1Sumhs/q8SOWxGgJl3i5cMM33jXskeK0p8yZi1njdxviyedJy1rtFNXondb38 o7gw== X-Gm-Message-State: AOAM530iwB9R4aqMT+ItAArM1XtViJrYESAiDxCZecc7GW+m/FBYh5wt /KOOADpdZm8lsjGZBFbA6v6SkNEeHx6HUx0/ X-Google-Smtp-Source: ABdhPJyrK41DmY4VCuhCdBU0E1npreaKMgNKdvVYn5B/OpWqCxdQfDLzKjp3NGHfzJ+vqFmGaDW2YQ== X-Received: by 2002:a05:600c:2f0f:: with SMTP id r15mr10370961wmn.166.1624450954871; Wed, 23 Jun 2021 05:22:34 -0700 (PDT) Received: from localhost (host86-140-92-85.range86-140.btcentralplus.com. [86.140.92.85]) by smtp.gmail.com with ESMTPSA id p8sm5783491wmi.46.2021.06.23.05.22.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 05:22:34 -0700 (PDT) Date: Wed, 23 Jun 2021 13:22:33 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/3] gdb: fix regression in evaluate_funcall for non C++ like cases Message-ID: <20210623122233.GM2568@embecosm.com> References: <20210622172447.1862794-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:21:39 up 6 days, 20:13, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 12:22:37 -0000 Doh! I posted these in-reply-to the wrong email. Please just ignore these, and I'll resend to the correct thread. Sorry for the noise, Andrew * Andrew Burgess [2021-06-23 12:39:12 +0100]: > Changes since v1: > > - Updated the commit message for patch #1 after Simon's query, > hopefully this should make it clearer what I'm talking about. > > - Passing a NULL terminated array around sucks now we have > array_view, patch #2 changes the API to use array_view, which > exposed another bug in this area (which is fixed in this patch). > > - After this discussion in the bug (gdb/27994), patch #3 updates the > API even further, we now make use of gdb::optional instead of > passing a pointer to an array_view. > > --- > > Andrew Burgess (3): > gdb: fix regression in evaluate_funcall for non C++ like cases > gdb: replace NULL terminated array with array_view > gdb: use gdb::optional instead of passing a pointer to gdb::array_view > > gdb/ChangeLog | 51 ++++++++++++++++++++ > gdb/ada-lang.c | 6 +-- > gdb/eval.c | 19 ++++++-- > gdb/f-lang.c | 2 +- > gdb/guile/scm-value.c | 2 +- > gdb/m2-lang.c | 4 +- > gdb/opencl-lang.c | 2 +- > gdb/python/py-value.c | 2 +- > gdb/rust-lang.c | 18 +++---- > gdb/testsuite/ChangeLog | 14 ++++++ > gdb/testsuite/gdb.cp/method-call-in-c.cc | 52 +++++++++++++++++++++ > gdb/testsuite/gdb.cp/method-call-in-c.exp | 48 +++++++++++++++++++ > gdb/valarith.c | 2 +- > gdb/valops.c | 57 ++++++++++++----------- > gdb/value.h | 2 +- > 15 files changed, 229 insertions(+), 52 deletions(-) > create mode 100644 gdb/testsuite/gdb.cp/method-call-in-c.cc > create mode 100644 gdb/testsuite/gdb.cp/method-call-in-c.exp > > -- > 2.25.4 >