From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 93F33393A410 for ; Fri, 25 Jun 2021 20:08:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93F33393A410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32b.google.com with SMTP id p8-20020a7bcc880000b02901dbb595a9f1so6576024wma.2 for ; Fri, 25 Jun 2021 13:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=508f5y9o80zjvDPZXaMB16kRlL3OpQZZ8x2olhcAEoU=; b=VSYob7HI9bW3gRmiPuK1dRoTjIuLRZBzZaMz3YznYDweiEdKaiIy6r/IDgrHKK3ZEQ jyFzOZvnirGxS6lJjLhfU9A7/AYEjMxbNgJdwwWDTKTU9Dez4Ce6bateMzbOgU2aWARC ry9Rv6uQpBYiOwOJKT1/bH3kkSJj16bM4l9nyHBGzTHBDW1oHIH466lsBVyqkKPpYCDp aVtBRDmTptlJ4L0AfKsn3Y5XFpD2LIpR1hsmtPkZlQR4vrd/1VCQJtUjlMeSm2MvZsh8 /x7WrdnhQAxX84Tmm4rEa8kxnRAn0fdo7j06Suhkk1aYm6iUbfYCvHV3A88FkSJOk+bR vCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=508f5y9o80zjvDPZXaMB16kRlL3OpQZZ8x2olhcAEoU=; b=aihvIWYYAjwqb5qlFZQI5JZfE8eXm5WJ6y8nytSIsNlcVvItMjs11tBBymO6bfXwz8 yiQjmjbV3NvRvjrcqyOnpZcbuyfxK7iOBOq/d2+C8qYMZ62K58SzrTJAqKGlsW2k1XHy tLcQ/isdtza/DD5xim3vEqhBNba8dihQOGwYHWxCbwwiYmEgu+zEbsD8Ce3Z6L+OO4Ql eBSim4E5Lggr80XxhuFxxN+dtkm6ln6r7BjZUeNagv4LEJt5Lpkj1EYfpvN+93tdZlqg iuEst3UxEPtYtjSsSpIZPVyZJcQ4i13eRiuR4iHflAL2yoxwD6JBY24qDtUsXxXZpskV biwg== X-Gm-Message-State: AOAM531PDzYztmWpmAfjeOGFWlIGYmWfb4AvMxGEV5XSjWcnQ0WrdpiJ qKlGaz03OAlYSz9JEw9yI+ZBUkyqg1WjtH1a X-Google-Smtp-Source: ABdhPJzpJXuVcbSluE0nNmhs0uknKOyxDZG8MeFVYTSGjFREPleu7Qo5UzO4497JHNsnp/O52TbrKg== X-Received: by 2002:a05:600c:4f53:: with SMTP id m19mr12762814wmq.36.1624651723556; Fri, 25 Jun 2021 13:08:43 -0700 (PDT) Received: from localhost (host86-140-92-85.range86-140.btcentralplus.com. [86.140.92.85]) by smtp.gmail.com with ESMTPSA id x81sm14135970wmg.36.2021.06.25.13.08.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 13:08:43 -0700 (PDT) Date: Fri, 25 Jun 2021 21:08:42 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: PING! Re: [PATCHv3 0/5] "info sources" - group by objfile Message-ID: <20210625200842.GP2568@embecosm.com> References: <20210621120201.GC2568@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621120201.GC2568@embecosm.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 21:08:24 up 9 days, 3:59, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 20:08:46 -0000 * Andrew Burgess [2021-06-21 13:02:01 +0100]: > I plan to push v3 later this week. I've now pushed this series. Thanks, Andrew > > The first two versions of this patch have had no negative feedback, > and the changes in v3 are minor over v2. > > Thanks, > Andrew > > > * Andrew Burgess [2021-06-07 19:32:22 +0100]: > > > In V3: > > > > - 'info sources' now indicates when an objfile has no debug > > information at all, this is a slight change of code, and an update > > to the commit message in patch #5. > > > > - the MI output is updated to include the same information, there are > > code changes, an update of the commit message, and changes to the > > documentation in patch #4. > > > > - all the other patches are unchanged. > > > > Thanks, > > Andrew > > > > > > --- > > > > Andrew Burgess (5): > > gdb: add new function quick_symbol_functions::has_unexpanded_symbols > > gdb: make struct output_source_filename_data more C++ like > > gdb/mi: add regexp filtering to -file-list-exec-source-files > > gdb/mi: add new --group-by-objfile flag for > > -file-list-exec-source-files > > gdb: change info sources to group results by objfile > > > > gdb/ChangeLog | 111 ++++++ > > gdb/NEWS | 31 ++ > > gdb/doc/ChangeLog | 15 + > > gdb/doc/gdb.texinfo | 176 +++++++-- > > gdb/dwarf2/read.c | 22 ++ > > gdb/mi/mi-cmd-file.c | 92 +++-- > > gdb/objfiles.h | 6 + > > gdb/psympriv.h | 2 + > > gdb/psymtab.c | 18 + > > gdb/quick-symbol.h | 6 + > > gdb/symfile-debug.c | 25 ++ > > gdb/symtab.c | 364 ++++++++++++------ > > gdb/symtab.h | 59 +++ > > gdb/testsuite/ChangeLog | 19 + > > .../gdb.base/info_sources_2-header.h | 28 ++ > > gdb/testsuite/gdb.base/info_sources_2-lib.c | 25 ++ > > gdb/testsuite/gdb.base/info_sources_2-test.c | 26 ++ > > gdb/testsuite/gdb.base/info_sources_2.exp | 169 ++++++++ > > gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 2 +- > > gdb/testsuite/gdb.mi/mi-file.exp | 2 +- > > gdb/testsuite/gdb.mi/mi-info-sources-base.c | 23 ++ > > gdb/testsuite/gdb.mi/mi-info-sources.c | 25 ++ > > gdb/testsuite/gdb.mi/mi-info-sources.exp | 184 +++++++++ > > 23 files changed, 1239 insertions(+), 191 deletions(-) > > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h > > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c > > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c > > create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp > > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c > > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c > > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp > > > > -- > > 2.25.4 > >