From: Lancelot SIX <lsix@lancelotsix.com>
To: gdb-patches@sourceware.org
Cc: Lancelot SIX <lsix@lancelotsix.com>
Subject: [PATCH] Remove unused parameter in maybe_software_singlestep
Date: Wed, 30 Jun 2021 22:30:33 +0100 [thread overview]
Message-ID: <20210630213033.593188-1-lsix@lancelotsix.com> (raw)
While working around, I noticed that the last parameter of
maybe_software_singlestep is never used. This path removes
it.
Built on x86_64-linux-gnu and riscv64-linux-gnu.
gdb/ChangeLog:
* infrun.c (maybe_software_singlestep): Remove unused PC
parameter.
(resume_1): Update calls to maybe_software_singlestep.
---
gdb/infrun.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 9469b74af39..eda713d9fb3 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -89,7 +89,7 @@ static void insert_step_resume_breakpoint_at_caller (struct frame_info *);
static void insert_longjmp_resume_breakpoint (struct gdbarch *, CORE_ADDR);
-static bool maybe_software_singlestep (struct gdbarch *gdbarch, CORE_ADDR pc);
+static bool maybe_software_singlestep (struct gdbarch *gdbarch);
static void resume (gdb_signal sig);
@@ -2051,11 +2051,10 @@ bool sched_multi = false;
/* Try to setup for software single stepping over the specified location.
Return true if target_resume() should use hardware single step.
- GDBARCH the current gdbarch.
- PC the location to step over. */
+ GDBARCH the current gdbarch. */
static bool
-maybe_software_singlestep (struct gdbarch *gdbarch, CORE_ADDR pc)
+maybe_software_singlestep (struct gdbarch *gdbarch)
{
bool hw_step = true;
@@ -2390,7 +2389,7 @@ resume_1 (enum gdb_signal sig)
set_step_over_info (regcache->aspace (),
regcache_read_pc (regcache), 0, tp->global_num);
- step = maybe_software_singlestep (gdbarch, pc);
+ step = maybe_software_singlestep (gdbarch);
insert_breakpoints ();
}
@@ -2409,7 +2408,7 @@ resume_1 (enum gdb_signal sig)
/* Do we need to do it the hard way, w/temp breakpoints? */
else if (step)
- step = maybe_software_singlestep (gdbarch, pc);
+ step = maybe_software_singlestep (gdbarch);
/* Currently, our software single-step implementation leads to different
results than hardware single-stepping in one situation: when stepping
--
2.31.1
next reply other threads:[~2021-06-30 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 21:30 Lancelot SIX [this message]
2021-07-01 13:12 ` Tom Tromey
2021-07-08 23:23 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630213033.593188-1-lsix@lancelotsix.com \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).