public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <lsix@lancelotsix.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.base/sigstep.exp: Mark xfail on unsupported scenarios on riscv64-linux-gnu
Date: Mon, 5 Jul 2021 17:32:21 +0000	[thread overview]
Message-ID: <20210705173221.luhvvcipq6uwdigz@ubuntu.lan> (raw)
In-Reply-To: <05ff5032-5e05-a1e1-50e3-6f5569472ca3@palves.net>

On Mon, Jul 05, 2021 at 11:26:15AM +0100, Pedro Alves wrote:
> There's already a "can_single_step_to_signal_handler" proc in gdb.exp for this.
> 
>  # Return 1 if target hardware or OS supports single stepping to signal
>  # handler, otherwise, return 0.
> 
>  proc can_single_step_to_signal_handler {} {
>      # Targets don't have hardware single step.  On these targets, when
>      # a signal is delivered during software single step, gdb is unable
>      # to determine the next instruction addresses, because start of signal
>      # handler is one of them.
>      return [can_hardware_single_step]
>  }
> 
> this is already checked by sigstep.exp, here:
> 
>  foreach enter_cmd { "stepi" "nexti" "step" "next" "continue" } {
>      if { $enter_cmd != "continue" && ![can_single_step_to_signal_handler] } {
>          continue
>      }
> 
> You should just need to make can_hardware_single_step return false for riscv64.
> 

Indeed.

Thanks for pointing this out!

Lancelot.

      reply	other threads:[~2021-07-05 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04 17:00 Lancelot SIX
2021-07-05  8:39 ` Andrew Burgess
2021-07-05 17:23   ` Lancelot SIX
2021-07-05 10:26 ` Pedro Alves
2021-07-05 17:32   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210705173221.luhvvcipq6uwdigz@ubuntu.lan \
    --to=lsix@lancelotsix.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).