From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by sourceware.org (Postfix) with ESMTPS id 63955388800D for ; Tue, 6 Jul 2021 11:43:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63955388800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f45.google.com with SMTP id u8so25673827wrq.8 for ; Tue, 06 Jul 2021 04:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MO6NPsGzKbMrLd8aOKXCachgrAoIZS7eWwKWZZ49ta0=; b=rPEZaIOdOIZHuDonitX+kbEbU4mfnD1JVwYLGgpjlwHsEGiZja8kcHm5uoG5lv/GdD 2j//9vJkRRTeHoXaR4CLxWc2P+6qWDT4lhcRUT0PBZFL6H9fIlNoLZ7SBBGe4aEPsSP6 6owadK0j5RuJ809ofriS5xY80ajo3cS3eougEIrzvXFgPiPhw7mibYDxxl652RZs6Mtp CKA34G12ZjcHuIkV04TeynKapx/PSOf32Ulcr/1FN/9bM2GysEpY2j2ncMxCxYf4/a6T DIVxbevqtpLMp0cic2Terf5oMd0bymuQTA85D/pGYhefkN4g9OtGKZx92i8ca8Mog+V+ t4DA== X-Gm-Message-State: AOAM532FEq4EeVMfyNRyE9rhG3/1QBFkCD/oHlnhyHe5hG82SkJ5tfEh /X7Y1iGF2z60H3CyaLCQ7wCRfVXUSuCXsw== X-Google-Smtp-Source: ABdhPJwDbb7Z+AO8yLFwhAKcQNZ8mbiX3dLYmDOP2LtnnRb2td2B04jinwe1VFlezgUYF5q3RoDNlg== X-Received: by 2002:a5d:414f:: with SMTP id c15mr20740745wrq.86.1625571811988; Tue, 06 Jul 2021 04:43:31 -0700 (PDT) Received: from localhost ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id x187sm6727371wmb.47.2021.07.06.04.43.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 04:43:31 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 3/3] Fix 'FAIL: gdb.perf/disassemble.exp: python Disassemble().run()' Date: Tue, 6 Jul 2021 12:43:23 +0100 Message-Id: <20210706114323.4177388-4-pedro@palves.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210706114323.4177388-1-pedro@palves.net> References: <20210706114323.4177388-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 11:43:34 -0000 We currently have one FAIL while running "make check-perf": PerfTest::assemble, run ... python Disassemble().run() Traceback (most recent call last): File "", line 1, in File "/home/pedro/rocm/gdb/src/gdb/testsuite/gdb.perf/lib/perftest/perftest.py", line 64, in run self.warm_up() File "", line 25, in warm_up gdb.error: No symbol "ada_evaluate_subexp" in current context. Error while executing Python code. (gdb) FAIL: gdb.perf/disassemble.exp: python Disassemble().run() ... The gdb.perf/disassemble.exp testcase debugs GDB with itself, runs to main, and then disassembles a few GDB functions. The problem is that most(!) functions it is trying to disassemble are now gone... This commit fixes the issue by simply picking some other functions to disassemble. It would perhaps be better to come up with some test program to disassemble, one that would stay the same throughout the years, instead of disassembling GDB itself. I don't know why that wasn't done to begin with. I'll have to leave that for another rainy day, though. gdb/testsuite/ yyyy-mm-dd Pedro Alves * gdb.perf/disassemble.py (Disassemble::warm_up): Disassemble evaluate_subexp_do_call instead of ada_evaluate_subexp. (Disassemble::warm_up): Disassemble "captured_main", "run_inferior_call" and "update_global_location_list" instead of "evaluate_subexp_standard" and "c_parse_internal". Change-Id: I89d1cca89ce2e495dea5096e439685739cc0d3df --- gdb/testsuite/gdb.perf/disassemble.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.perf/disassemble.py b/gdb/testsuite/gdb.perf/disassemble.py index 89634912fba..bbb2a16fda1 100644 --- a/gdb/testsuite/gdb.perf/disassemble.py +++ b/gdb/testsuite/gdb.perf/disassemble.py @@ -21,14 +21,15 @@ class Disassemble(perftest.TestCaseWithBasicMeasurements): super(Disassemble, self).__init__("disassemble") def warm_up(self): - do_test_command = "disassemble ada_evaluate_subexp" + do_test_command = "disassemble evaluate_subexp_do_call" gdb.execute(do_test_command, False, True) def _do_test(self, c): for func in [ - "evaluate_subexp_standard", + "captured_main", "handle_inferior_event", - "c_parse_internal", + "run_inferior_call", + "update_global_location_list", ]: do_test_command = "disassemble %s" % func for _ in range(c + 1): -- 2.26.2