From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tom@tromey.com>
Cc: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove unused parameter in maybe_software_singlestep
Date: Thu, 8 Jul 2021 23:23:00 +0000 [thread overview]
Message-ID: <20210708232240.fd66jh23sazdlzl7@ubuntu.lan> (raw)
In-Reply-To: <87fswyp49m.fsf@tromey.com>
Hi,
I have pushed this to master, with a minor modification to the comment
for maybe_software_singlestep. It stilles contained reference to the
removed parameter, I changed it from
/* Try to setup for software single stepping over the specified location.
Return true if target_resume() should use hardware single step.
to
/* Try to setup for software single stepping. Return true if target_resume()
should use hardware single step.
Lancelot.
On Thu, Jul 01, 2021 at 07:12:05AM -0600, Tom Tromey wrote:
> >>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Lancelot> While working around, I noticed that the last parameter of
> Lancelot> maybe_software_singlestep is never used. This path removes
>
> Typo in the text here, "path" -> "patch".
>
> Lancelot> gdb/ChangeLog:
>
> Lancelot> * infrun.c (maybe_software_singlestep): Remove unused PC
> Lancelot> parameter.
> Lancelot> (resume_1): Update calls to maybe_software_singlestep.
>
> Looks good. Thank you.
>
> Tom
prev parent reply other threads:[~2021-07-08 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 21:30 Lancelot SIX
2021-07-01 13:12 ` Tom Tromey
2021-07-08 23:23 ` Lancelot SIX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708232240.fd66jh23sazdlzl7@ubuntu.lan \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).