From: Jiangshuai Li <jiangshuai_li@c-sky.com>
To: gdb-patches@sourceware.org
Cc: jiangshuai_li@c-sky.com, lifang_xia@c-sky.com, yunhai_shang@c-sky.com
Subject: [PATCH 1/1] gdb:csky rm tdesc_has_registers in csky_register_name
Date: Thu, 15 Jul 2021 15:22:11 +0800 [thread overview]
Message-ID: <20210715072211.14917-2-jiangshuai_li@c-sky.com> (raw)
In-Reply-To: <20210715072211.14917-1-jiangshuai_li@c-sky.com>
As CSKY arch has not parsed target-description.xml in csky_gdbarch_init,
when a remote server, like csky-qemu or gdbserver, send a target-description.xml
to gdb, tdesc_has_registers will return ture, but tdesc_register_name (gdbarch, 0)
will return NULL, so a cmd "info registers r0" will not work.
Function of parsing target-description.xml will be add later for CSKY arch,
now it is temporarily removed to allow me to do other supported tests.
2021-07-15 Jiangshuai Li <jiangshuai_li@c-sky.com>
* csky-tdep.c : not using tdesc funtions in csky_register_name
---
gdb/csky-tdep.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
index 5940429e192..657ba75d080 100644
--- a/gdb/csky-tdep.c
+++ b/gdb/csky-tdep.c
@@ -235,9 +235,6 @@ static const char * const csky_register_names[] =
static const char *
csky_register_name (struct gdbarch *gdbarch, int reg_nr)
{
- if (tdesc_has_registers (gdbarch_target_desc (gdbarch)))
- return tdesc_register_name (gdbarch, reg_nr);
-
if (reg_nr < 0)
return NULL;
--
2.17.1
next prev parent reply other threads:[~2021-07-15 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 7:22 [PATCH 0/1] Improve CSKY arch support Jiangshuai Li
2021-07-15 7:22 ` Jiangshuai Li [this message]
2021-08-03 10:19 ` [PATCH 1/1] gdb:csky rm tdesc_has_registers in csky_register_name Andrew Burgess
2021-08-12 8:51 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715072211.14917-2-jiangshuai_li@c-sky.com \
--to=jiangshuai_li@c-sky.com \
--cc=gdb-patches@sourceware.org \
--cc=lifang_xia@c-sky.com \
--cc=yunhai_shang@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).