From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 5E54D397B82A for ; Tue, 27 Jul 2021 10:06:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E54D397B82A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x436.google.com with SMTP id n12so10949014wrr.2 for ; Tue, 27 Jul 2021 03:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6pptxqbPxGWYh5sn/W+Rcnc2jy8v3ENO9l5ciRfpJVA=; b=eRz6osyKWyD6hT0/pbgE12Mm+OFW/YE8k+V3q28ia4QOJz7cbBBbGhS7oDb46Qwji1 fZLQQMIlTQXxEtUjYBJWjj/i2oVu2C0qjPtCqAVJG1nxRT1J2PlYney5B3y/Y57f4t5g 9PUSXAwLXbS0lLBxlu7HfEiv/7iBZEP01FcjX5x1IZmY/xZEGGdccm0CxGxQX6egxcZJ uKzCRalnN5VfD6+NklsjYi0RsFCoQHXNtP6QXx1kJCKG0PnRp/Rn10RREiicMg+8AvEa V46IYDhwKc6bZGqZ3H4ahrWUacfJFLrZy+h4578vUdoj4ObymqIzALNZp0P+jWhoVdXH ByuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6pptxqbPxGWYh5sn/W+Rcnc2jy8v3ENO9l5ciRfpJVA=; b=KfB2MDJ7mhT40lxp/NOFt0omo0iFRoaPIVSi2tgp0xu8gWkzUT3q56KJ3kDP8d5CrE lwBm5CqohIzhurKYbji51ZM+iYtOXh0pAxk5mtnHOhWPO7XH5YX4m+PrYoW9KnGOSa2V jQQxv+rYC78QhKpzWCSDOnZpnCeVmqNpokYoyaTQGoebLeShvmOyXecZFcjH+BGG4Es6 ZnDl4CCamPgwZO4qBdtKPoy57mm/wUt14BptMw9RoLffvav1J5ZBN7FO/DcGQrQBgQut GnO3ON75IZ+W5gNvGazHNOZr5PiXUQkcvscGmXgf+iSX4O+zgJVFruadVSTJyDGhU8rc bPzA== X-Gm-Message-State: AOAM5322wY4Yy5bYDk1CAOATvI8WVys+4Hp35eCBBZn6EsJBDK6FQR8l RoRsPT6noBTi3pRzdQs5XbEovw== X-Google-Smtp-Source: ABdhPJwo7QLv1d0Aq3cks75h2PNfR08LzFUGIezeGCpJY+SAybAfstvnu+RLoVZGogwpobhcIsI07g== X-Received: by 2002:adf:f149:: with SMTP id y9mr5418206wro.413.1627380366909; Tue, 27 Jul 2021 03:06:06 -0700 (PDT) Received: from localhost (host86-161-16-194.range86-161.btcentralplus.com. [86.161.16.194]) by smtp.gmail.com with ESMTPSA id l39sm1769157wms.1.2021.07.27.03.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 03:06:05 -0700 (PDT) Date: Tue, 27 Jul 2021 11:06:04 +0100 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Message-ID: <20210727100604.GL1872618@embecosm.com> References: <0e7ab535-8c62-cd78-487e-f076d022388f@polymtl.ca> <20210726111149.GG1872618@embecosm.com> <1475fb4d-0bab-7fac-134b-7dad9acd6a6b@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475fb4d-0bab-7fac-134b-7dad9acd6a6b@polymtl.ca> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 11:05:43 up 10 days, 20:39, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 10:06:09 -0000 * Simon Marchi [2021-07-26 09:57:02 -0400]: > On 2021-07-26 7:11 a.m., Andrew Burgess wrote: > > * Simon Marchi [2021-07-20 17:59:45 -0400]: > > > >> On 2021-07-20 5:10 a.m., Andrew Burgess wrote: > >>> Thanks for the feedback on v2. > >>> > >>> In v3 I have: > >>> > >>> - Addressed all of Pedro's feedback on the test in patch #1. > >>> > >>> - Rewritten how the problem in patch #1 is fixed based on Simon's > >>> exception based approach. > >>> > >>> Thanks, > >>> Andrew > >> > >> When speaking to Pedro off-line, it did sound like he had concerns with > >> what I proposed, so let's wait to hear what he has to say. > > > > That's fine. Hopefully Pedro will be able to offer some feedback > > soon. > > > > Before then, I've spun off patch #2 and an additional fix related to > > 'set debug frame on' into a separate patch (below). I think all of > > this code is unrelated to the whole should we use an exception, or > > change the API of get_prev_frame. > > > > What are your thoughts on this patch? > > > > Additionally, this one might be a possible candidate for merging into > > gdb-11-branch. Here's a ChangeLog if we decide that's a good idea. > > > > gdb/ChangeLog: > > * frame.c (get_prev_frame_always_1): Handle case where > > this_frame->prev is nullptr. > > (get_prev_frame_id_by_id): Delete. > > * frame.h (get_prev_frame_id_by_id): Delete declaration. > > * valops.c (value_assign): Remove use of VALUE_FRAME_ID. > > * vaule.c (value_fetch_lazy_register): Likewise. > > * value.h (VALUE_FRAME_ID): Delete. > > > > gdb/testsuite/ChangeLog: > > * gdb.base/premature-dummy-frame-removal.exp: Repeat test with > > 'set debug frame on' in effect. > > > > Thanks, > > Andrew > > The patch below does LGTM, thanks. Thanks, I pushed this just to master for now. Andrew