Re: [PATCH, rs6000] Add ppc64*_gnu_triplet_regexp methods.

[Lancelot SIX <lsix@lancelotsix.com>]

> +/* Specify the powerpc64le target triplet.
> +   This can be variations of
> +	ppc64le-{distro}-linux-gcc
> +   and
> +	powerpc64le-{distro}-linux-gcc
> +   */
> +static const char *
> +ppc64le_gnu_triplet_regexp (struct gdbarch *gdbarch)
> +{
> +        return "p(ower)*pc64le?";
> +}
> +
> +/* Specify the powerpc64 target triplet.
> +   This can be variations of
> +	ppc64-{distro}-linux-gcc
> +   and
> +	powerpc64-{distro}-linux-gcc
> +   */
> +static const char *
> +ppc64_gnu_triplet_regexp (struct gdbarch *gdbarch)
> +{
> +        return "p(ower)*pc64?";
> +}
> +

Hi,

It looks like that the first '*' in both of your regex says that 'ower'
can be matched any number of time.  With this, something like
'powerowerpc64' will match.  You should replace them with '?' (which
stands for “match 0 or 1 time”).

Also, the last '?' of your says that the last char is optional, and
should probably be removed.

With that given into account, I think your patterns should look
something like:

- "p(ower)?pc64le"
- "p(ower)?pc64"

I think that a '-' is appended right after this so there should not be
an issue with the second pattern matching for 'ppc64le'.  If there is an
issue here, it should be possible to append '(?!l)' (which means “not
followed by a 'l'”), but I am not sure if this is supported by the regex
library used by GDB.

(I have not tested those, but they should work with pretty much any
regex library).

Best,
Lancelot.