From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id B3DE6385AC2C for ; Fri, 13 Aug 2021 09:14:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B3DE6385AC2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x42b.google.com with SMTP id b13so12347540wrs.3 for ; Fri, 13 Aug 2021 02:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=iPyWx9+7F9z9tUnvBAj8oGhhBAjL+ahoh/lzKpq5zvQ=; b=a4jG/Hp+F5AriCJcb2NgSjwtqRqnreNPt+3U2yDglQbEf/cJFty5Zd6UIujme/pDQO m6N0ybyjDMQwa01hLl151ViMEHZLytk8VjAdVZ4AQcdpxkIDeF+meG+oNlpMvkUuKZwl gIPotKhTLD98FMkvIx/Kia+bnrQrgzsdj3tCPlVF0/OeWJwn6jjM+NAmJrwv0PCbNI2b uZXeJhGZYJ4+z6k0cz5cit10CsLKwcoLzL4nprE+3vtNG1MCCOU4alOv9UgHrsvNa4ok Zx4xk+KO2mTEzn57SOgcJ7+nJqg1/THdzGlQYVjUnsaeA2xnKkwdNP2Xa+JgIWBxDega uPVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=iPyWx9+7F9z9tUnvBAj8oGhhBAjL+ahoh/lzKpq5zvQ=; b=rn/U/nWTeuEBTiAddMkDVqQZIiW8RK/QdOF7DHf3rjFE8qmuZab8IVHMGqsT63pBIE QANlvD7eXewoN2JLWncTTMmwPW6OGjCgPC1d3efQaOxdyiKYIpftdHcwcw3b7gKHoArC sdPsHdU/G8mW125PDfC4rgwUYXENNv4zvyo735XSwbHfVfJQIb6DuaMLxYPmgvqoo1Dk 3+8ev/D1NSGj14l+/jlrAQCv7vuk/25StqNh2r/tlGOZCAoZepr8Ol3OtyUWwUd+f/wm VBKrHQLZPypUzbzsTiknTR+xe29+NYrKcgcgmUQE+n9tkAspIGcb3I1QLk3iCLaUaGz2 qDXg== X-Gm-Message-State: AOAM533feMyP2Bel5reePYAMkjCA4xw7U03o1YBvunWmX8e4LlbVSuMw OF7gsYk4J3TxNPkkI4dg5Wq23+5Syv7EeA== X-Google-Smtp-Source: ABdhPJz6QraJzZpd3I6DEeifXUEhz7CMjRgWcv1KnUmxhDD6Kp1kpw4B6zzbAIhpB5X6/hQsgrh1LQ== X-Received: by 2002:adf:ee0d:: with SMTP id y13mr1862007wrn.317.1628846095785; Fri, 13 Aug 2021 02:14:55 -0700 (PDT) Received: from localhost (host86-175-180-250.range86-175.btcentralplus.com. [86.175.180.250]) by smtp.gmail.com with ESMTPSA id r10sm934595wrp.28.2021.08.13.02.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 02:14:55 -0700 (PDT) Date: Fri, 13 Aug 2021 10:14:53 +0100 From: Andrew Burgess To: Lancelot SIX Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: riscv_scan_prologue: handle LD and LW instructions Message-ID: <20210813091453.GK462163@embecosm.com> References: <20210810223754.1479173-1-lsix@lancelotsix.com> <20210811155306.GG462163@embecosm.com> <20210812232638.h2ekf5n4kgyupzsd@ubuntu.lan> <20210812234419.b4rfjin737taw5bb@ubuntu.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210812234419.b4rfjin737taw5bb@ubuntu.lan> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:14:30 up 11 days, 14:54, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2021 09:15:07 -0000 * Lancelot SIX [2021-08-12 23:44:19 +0000]: > On Thu, Aug 12, 2021 at 11:26:38PM +0000, Lancelot SIX via Gdb-patches wr= ote: > > >=20 > > > LGTM. > > >=20 > > > Thanks for doing this. > > >=20 > > > Andrew > > >=20 > >=20 > > I just pushed it. > >=20 > > Lancelot. >=20 > Actually, I=C2=A0just realized that one of the testfile was not properly > named. It is probably not critical, keep it tidy, I=E2=80=99ll rename th= e .c > file to match the name of the testcase. >=20 > Is the following patch OK? LGTM. Sorry for not catching this. Thanks, Andrew >=20 > --- > From bda6d870e1202ceb113de369b8a109d495b8d4d7 Mon Sep 17 00:00:00 2001 > From: Lancelot SIX > Date: Thu, 12 Aug 2021 23:29:08 +0000 > Subject: [PATCH] gdb: rename > gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit >=20 > A=C2=A0previous commit added the > gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp testcase, but one of its > associated file was named after a previous version of the test. >=20 > This commit fixes this and makes sure that all the files linked to this > testcase share the same prefix in the name. >=20 > Tested on riscv64 GNU/Linux. > --- > ...-prologue-with-ld.c =3D> riscv64-unwind-prologue-with-ld-lw.c} | 0 > gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp | 2 +- > 2 files changed, 1 insertion(+), 1 deletion(-) > rename gdb/testsuite/gdb.arch/{riscv64-unwind-prologue-with-ld.c =3D> ri= scv64-unwind-prologue-with-ld-lw.c} (100%) >=20 > diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld.c b/g= db/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c > similarity index 100% > rename from gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld.c > rename to gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.c > diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.ex= p b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp > index c329d2f72e0..f559c3ff4bc 100644 > --- a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp > +++ b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp > @@ -21,7 +21,7 @@ if {![istarget "riscv64-*-*"]} { > return > } > =20 > -standard_testfile riscv64-unwind-prologue-with-ld.c \ > +standard_testfile riscv64-unwind-prologue-with-ld-lw.c \ > riscv64-unwind-prologue-with-ld-lw-foo.s > if {[prepare_for_testing "failed to prepare" $testfile \ > "$srcfile $srcfile2" nodebug]} { > --=20 > 2.30.2