From: Kevin Buettner <kevinb@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Test case reproducing PR28030 bug
Date: Fri, 3 Sep 2021 08:57:06 -0700 [thread overview]
Message-ID: <20210903085706.0e816e17@f33-m1.lan> (raw)
In-Reply-To: <74a3d3bf-9763-8329-981f-972ef5494a0b@polymtl.ca>
On Fri, 3 Sep 2021 08:23:36 -0400
Simon Marchi <simon.marchi@polymtl.ca> wrote:
> When applying, git-am says:
>
>
> Applying: Test case reproducing PR28030 bug
> .git/rebase-apply/patch:228: trailing whitespace.
> # Create the DWARF.
> .git/rebase-apply/patch:232: trailing whitespace.
> # Find start, end, and length of functions foo and bar.
> .git/rebase-apply/patch:259: trailing whitespace.
>
> .git/rebase-apply/patch:447: trailing whitespace.
> # We don't want a clean restart here since that will be too clean.
> warning: 4 lines add whitespace errors.
>
> Can you fix those?
Yes. I've fixed those problems.
> Otherwise, LGTM.
Thanks for the reviews.
I've pushed this commit.
Kevin
prev parent reply other threads:[~2021-09-03 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 6:17 Kevin Buettner
2021-09-03 12:23 ` Simon Marchi
2021-09-03 15:57 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903085706.0e816e17@f33-m1.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).