From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
 by sourceware.org (Postfix) with ESMTPS id D76423858C2C
 for <gdb-patches@sourceware.org>; Thu,  9 Sep 2021 23:33:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D76423858C2C
Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id C0DA581C29;
 Thu,  9 Sep 2021 23:33:02 +0000 (UTC)
Date: Thu, 9 Sep 2021 23:32:58 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 15/30] Introduce the new DWARF index class
Message-ID: <20210909233258.isik6vgmogphkcas@ubuntu.lan>
References: <20210826021937.1490292-1-tom@tromey.com>
 <20210826021937.1490292-16-tom@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210826021937.1490292-16-tom@tromey.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Thu, 09 Sep 2021 23:33:02 +0000 (UTC)
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Sep 2021 23:33:05 -0000

> +  /* GNAT only emits mangled ("encoded") names in the DWARF, and does
> +     not emit the module structure.  However, we need this structure
> +     to do lookups.  This function recreates that structure for an
> +     existing returns the base name (last element) of the full decoded

Hi Tom,

I think something is missing between 'existing' and 'returns'.  Did you
mean something like "This function recreates that structure.  Returns
the base name (last element) of the fully decoded name."?

Best,
Lancelot.

> +     name.  */
> +  gdb::unique_xmalloc_ptr<char> handle_gnat_encoded_entry
> +       (cooked_index_entry *entry, htab_t gnat_entries);