* [committed][gdb/tdep] Reset force_thumb in parse_arm_disassembler_options
@ 2021-09-13 18:17 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-09-13 18:17 UTC (permalink / raw)
To: gdb-patches
Hi,
With a gdb build with --enable-targets=all, we have 2 arch-specific failures
in selftest print_one_insn:
...
$ gdb -q -batch a.out -ex "maint selftest print_one_insn" 2>&1 \
| grep "Self test failed: arch "
Self test failed: arch armv8.1-m.main: self-test failed at \
disasm-selftests.c:165
Self test failed: arch arm_any: self-test failed at disasm-selftests.c:165
$
...
During the first failed test, force_thumb is set to true, and remains so until
and during the second test, which causes the second failure.
Fix this by resetting force_thumb to false in parse_arm_disassembler_options,
such that we get just one failure:
...
$ gdb -q -batch a.out -ex "maint selftest print_one_insn" 2>&1 \
| grep "Self test failed: arch "
Self test failed: arch armv8.1-m.main: self-test failed at \
disasm-selftests.c:165
$
...
Tested on x86_64-linux.
Committed to trunk, as obvious.
Thanks,
- Tom
[gdb/tdep] Reset force_thumb in parse_arm_disassembler_options
---
opcodes/arm-dis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index faabd42b5b3..78efb815147 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -11613,6 +11613,7 @@ parse_arm_disassembler_options (const char *options)
{
const char *opt;
+ force_thumb = false;
FOR_EACH_DISASSEMBLER_OPTION (opt, options)
{
if (startswith (opt, "reg-names-"))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-13 18:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 18:17 [committed][gdb/tdep] Reset force_thumb in parse_arm_disassembler_options Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).