Re: [PUSHED 5/6] gdb: use libbacktrace to create a better backtrace for fatal signals

[Andrew Burgess <andrew.burgess@embecosm.com>]

* Pedro Alves <pedro@palves.net> [2021-09-28 19:55:11 +0100]:

> Hi Andrew,
> 
> I read this now (for the first time, I completely missed v1!), and spotted a couple typos:
> 
> On 2021-09-28 12:26 p.m., Andrew Burgess wrote:
> 
> > +  return function != nullptr && strcmp (function, "main") == 0;
> > +}
> > +
> > +/* Write a backtrace to GDB's stderr in an async safe manor.  This is a
> 
> typo: manor -> manner.
> 
> > +/* Print a backtrace of the current GDB process to the current
> > +   gdb_stderr.  The output is done in a signal async manor, so it is safe
> 
> likewise.
> 
> 
> Thanks for doing all this.

Thanks, I fixed these.  I also found an additional instance of this
mistake which I fixed.

Below is what I pushed.

Thanks,
Andrew

---

commit 80656a8e4b32353025f7f4cb1279168f082fbf7b
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Wed Sep 29 09:16:52 2021 +0100

    gdb: fix manor -> manner typo in some comments
    
    In a recent commit I used 'manor' in some comments rather than
    'manner'.  This commit fixes those two mistakes.
    
    I also looked through the gdb/ tree and found one additional instance
    of this mistake that this commit also fixes.

diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c
index b5e0a0ed004..8f826bde6b4 100644
--- a/gdb/bt-utils.c
+++ b/gdb/bt-utils.c
@@ -108,7 +108,7 @@ libbacktrace_print (void *data, uintptr_t pc, const char *filename,
   return function != nullptr && strcmp (function, "main") == 0;
 }
 
-/* Write a backtrace to GDB's stderr in an async safe manor.  This is a
+/* Write a backtrace to GDB's stderr in an async safe manner.  This is a
    backtrace of GDB, not any running inferior, and is to be used when GDB
    crashes or hits some other error condition.  */
 
diff --git a/gdb/bt-utils.h b/gdb/bt-utils.h
index 433aa23614b..a406041ec64 100644
--- a/gdb/bt-utils.h
+++ b/gdb/bt-utils.h
@@ -49,7 +49,7 @@
 #endif
 
 /* Print a backtrace of the current GDB process to the current
-   gdb_stderr.  The output is done in a signal async manor, so it is safe
+   gdb_stderr.  The output is done in a signal async manner, so it is safe
    to call from signal handlers.  */
 
 extern void gdb_internal_backtrace ();
diff --git a/gdb/language.h b/gdb/language.h
index cec3ab03ed6..69101bd4074 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -574,7 +574,7 @@ struct language_defn
   /* Return false if the language has first-class arrays.  Return true if
      there are no array values, and array objects decay to pointers, as in
      C.  The default is true as currently most supported languages behave
-     in this manor.  */
+     in this manner.  */
 
   virtual bool c_style_arrays_p () const
   { return true; }