From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 14D493858D35 for ; Wed, 29 Sep 2021 08:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14D493858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32d.google.com with SMTP id r11-20020a1c440b000000b0030cf0f01fbaso3306747wma.1 for ; Wed, 29 Sep 2021 01:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rmxIX7ZPMuwWUEPZpc+gdsQtdfloc727Q5CBXpP2xW0=; b=Ej6t5w7IUxf5T0iQYPYllnSTDshHdCYrBvlclwPx1B1gYWpGMlHNQIoMyf7MlExild DzcwaoKbg4neqNceE9bdXzjlR9sFwqMEDnZsvcUWQ4w7T4njtZnltaa+YPQECz2gxUoW 0joKIjeR5ZUS3d95kVsuNPFFqIe/ZeIF7p05ZkJZOoye+SvAF8CG8QocV6Luht82BZRH hCSQxMveFQARF/zyBBpN8CY4MUUeR1yFunY7xs+kKNEDnzP0R+K5sa2GDUHYYuu2GSfa 8kgwGefII0D98+ViYp0qSx/snr9/reGG15Q9HZJIKZNe+j1Vk5C3eTl6ksNNJdmj0o0E xpvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rmxIX7ZPMuwWUEPZpc+gdsQtdfloc727Q5CBXpP2xW0=; b=n6kBVz5kRbod/0M5j595ycdyZVVtm6pgdQQsXh6J/BBOeQ1yNv7FlfVZsZhp06d0MQ HAONyy5DuuDjIL9iajk4OJN7vYFKu+2ZEX8NUpv2YnEX6okns5y9fW1w06W5IhLCEDut bXzgKtxrlnD/xHiuGLs24Slp8Btkzuh0BsjWIRvLQ7trhaU7PCCPmm7CzdUheQAOwzb/ PY/wmUqvdmQDeT20HrUfiyn7zTJU6GHRNch7IUWF4T5PSqWoYU3XGrJKhLH9TuYrto2v tCfBVCTGt7XNfpyL+eq2lms2m+6ufjO0Pfc+/DNVEMXjv9yMIbGwFa/VTJy+ppEE/vb9 52Lw== X-Gm-Message-State: AOAM532XSlFOM9QH95jrlV+ghSc1DS3aY0m4031hDPlkTAgjYATRRfAP 6vcsVWwPN5y6VuiEfv+hSsjEVnErycaCjg== X-Google-Smtp-Source: ABdhPJxfP83oaxE/tYQOybkuas3efnaQ5kHiW8my6BwRp09qsrJ6wrRDXhC0QV8qhJ4jQ8RldK3qUQ== X-Received: by 2002:a7b:cd82:: with SMTP id y2mr5767881wmj.106.1632903720014; Wed, 29 Sep 2021 01:22:00 -0700 (PDT) Received: from localhost (host86-169-137-11.range86-169.btcentralplus.com. [86.169.137.11]) by smtp.gmail.com with ESMTPSA id z6sm1102408wmp.1.2021.09.29.01.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 01:21:59 -0700 (PDT) Date: Wed, 29 Sep 2021 09:21:58 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PUSHED 5/6] gdb: use libbacktrace to create a better backtrace for fatal signals Message-ID: <20210929082158.GK1900093@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 09:20:54 up 9 days, 23:29, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 08:22:02 -0000 * Pedro Alves [2021-09-28 19:55:11 +0100]: > Hi Andrew, > > I read this now (for the first time, I completely missed v1!), and spotted a couple typos: > > On 2021-09-28 12:26 p.m., Andrew Burgess wrote: > > > + return function != nullptr && strcmp (function, "main") == 0; > > +} > > + > > +/* Write a backtrace to GDB's stderr in an async safe manor. This is a > > typo: manor -> manner. > > > +/* Print a backtrace of the current GDB process to the current > > + gdb_stderr. The output is done in a signal async manor, so it is safe > > likewise. > > > Thanks for doing all this. Thanks, I fixed these. I also found an additional instance of this mistake which I fixed. Below is what I pushed. Thanks, Andrew --- commit 80656a8e4b32353025f7f4cb1279168f082fbf7b Author: Andrew Burgess Date: Wed Sep 29 09:16:52 2021 +0100 gdb: fix manor -> manner typo in some comments In a recent commit I used 'manor' in some comments rather than 'manner'. This commit fixes those two mistakes. I also looked through the gdb/ tree and found one additional instance of this mistake that this commit also fixes. diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c index b5e0a0ed004..8f826bde6b4 100644 --- a/gdb/bt-utils.c +++ b/gdb/bt-utils.c @@ -108,7 +108,7 @@ libbacktrace_print (void *data, uintptr_t pc, const char *filename, return function != nullptr && strcmp (function, "main") == 0; } -/* Write a backtrace to GDB's stderr in an async safe manor. This is a +/* Write a backtrace to GDB's stderr in an async safe manner. This is a backtrace of GDB, not any running inferior, and is to be used when GDB crashes or hits some other error condition. */ diff --git a/gdb/bt-utils.h b/gdb/bt-utils.h index 433aa23614b..a406041ec64 100644 --- a/gdb/bt-utils.h +++ b/gdb/bt-utils.h @@ -49,7 +49,7 @@ #endif /* Print a backtrace of the current GDB process to the current - gdb_stderr. The output is done in a signal async manor, so it is safe + gdb_stderr. The output is done in a signal async manner, so it is safe to call from signal handlers. */ extern void gdb_internal_backtrace (); diff --git a/gdb/language.h b/gdb/language.h index cec3ab03ed6..69101bd4074 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -574,7 +574,7 @@ struct language_defn /* Return false if the language has first-class arrays. Return true if there are no array values, and array objects decay to pointers, as in C. The default is true as currently most supported languages behave - in this manor. */ + in this manner. */ virtual bool c_style_arrays_p () const { return true; }